Attention is currently required from: Johnny Lin, Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55745 )
Change subject: util/ifdtool: Add Cooper Lake platform support under IFDv2
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
yes +2 for patchset 1 and if you can split the patch into 2 CL ?
Why?
I believe first you wish to add support for CPX into IFDtool. and next step you would like to consider specific changes that is applicable for CPX chipset isn't it.
Some things would be wrong for CPX in patchset 1 if things are split up.
I agree, and you can always mention that in commit that incremental changes to add CPX changes in proper.
My only intention behind suggesting a split saying, CB:CB:54305 doesn't demand one to add those chipset specific changes for IFDv2 detection and reading this commit msg is giving that hint only.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I444e7d35a85d9d42fc25d654e57386f38cf1ec85
Gerrit-Change-Number: 55745
Gerrit-PatchSet: 4
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 23 Jun 2021 08:35:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment