Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35486 )
Change subject: Documentation: Reword Supermicro X10SLM+-F sentence ......................................................................
Documentation: Reword Supermicro X10SLM+-F sentence
Change-Id: I24c4254ef65edcddadcf0386e0cbe996a5e99458 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Documentation/mainboard/supermicro/x10slm-f.md 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/35486/1
diff --git a/Documentation/mainboard/supermicro/x10slm-f.md b/Documentation/mainboard/supermicro/x10slm-f.md index 8a91c89..7abbbfd 100644 --- a/Documentation/mainboard/supermicro/x10slm-f.md +++ b/Documentation/mainboard/supermicro/x10slm-f.md @@ -87,8 +87,7 @@
This board has an ASPEED [AST2400], which has BMC functionality. The BMC firmware resides in a 32 MiB SOIC-16 chip just above the [AST2400]. -This chip is an MX25L25635F, whose datasheet can be found -[here][MX25L25635F]. +This chip is an MX25L25635F ([datasheet](MX25L25635F).
### Removing the BMC functionality
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35486 )
Change subject: Documentation: Reword Supermicro X10SLM+-F sentence ......................................................................
Patch Set 1:
doesn't look like a valid markdown link
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35486
to look at the new patch set (#2).
Change subject: Documentation: Reword Supermicro X10SLM+-F sentence ......................................................................
Documentation: Reword Supermicro X10SLM+-F sentence
Change-Id: I24c4254ef65edcddadcf0386e0cbe996a5e99458 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Documentation/mainboard/supermicro/x10slm-f.md 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/35486/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35486
to look at the new patch set (#3).
Change subject: Documentation: Reword Supermicro X10SLM+-F datasheet references ......................................................................
Documentation: Reword Supermicro X10SLM+-F datasheet references
Change-Id: I24c4254ef65edcddadcf0386e0cbe996a5e99458 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Documentation/mainboard/supermicro/x10slm-f.md 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/35486/3
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35486 )
Change subject: Documentation: Reword Supermicro X10SLM+-F datasheet references ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35486 )
Change subject: Documentation: Reword Supermicro X10SLM+-F datasheet references ......................................................................
Documentation: Reword Supermicro X10SLM+-F datasheet references
Change-Id: I24c4254ef65edcddadcf0386e0cbe996a5e99458 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/35486 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Documentation/mainboard/supermicro/x10slm-f.md 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/Documentation/mainboard/supermicro/x10slm-f.md b/Documentation/mainboard/supermicro/x10slm-f.md index acb2c84..7036080 100644 --- a/Documentation/mainboard/supermicro/x10slm-f.md +++ b/Documentation/mainboard/supermicro/x10slm-f.md @@ -68,7 +68,7 @@ The main firmware flash chip is an SOIC-8 package located near the CMOS battery and SATA ports. It should come with a sticker attached that states the firmware revision (e.g. "X10SLH 4.424"). The chip model is -an N25Q128A, and the datasheet can be found [here][N25Q128A]. +an N25Q128A ([datasheet][N25Q128A]).
As with [internal programming](#internal-programming), [flashrom] works reliably: @@ -87,8 +87,7 @@
This board has an ASPEED [AST2400], which has BMC functionality. The BMC firmware resides in a 32 MiB SOIC-16 chip just above the [AST2400]. -This chip is an MX25L25635F, whose datasheet can be found -[here][MX25L25635F]. +This chip is an MX25L25635F ([datasheet][MX25L25635F]).
### Removing the BMC functionality
-
Patrick Georgi (Code Review) -
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)