Attention is currently required from: Ashish Kumar Mishra, Ashish Kumar Mishra, Bernardo Perez Priego, Li1 Feng, Tanu Malhotra.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80773?usp=email )
Change subject: mb/google/brox: support ISH
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80773/comment/9a32bdc0_2faf839a :
PS5, Line 297: chip drivers/intel/ish
: register "firmware_name" = ""brox_ish.bin""
: device generic 0 on
: probe ISH ISH_ENABLE
: end
: end
: chip drivers/intel/ish
: register "add_acpi_dma_property" = "true"
: device generic 0 on
: probe STORAGE STORAGE_UFS
: end
: end
@Karthik done.
@tanu, Sure I understand. We will go with this change to unblock the ISH validation efforts. I will upload a follow-up CL to update the device tree such that ISH full sensing capability is enabled only when required. For that some additional changes are required.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80773?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iadc5108c62737d27642a6948c00b5c122541aaba
Gerrit-Change-Number: 80773
Gerrit-PatchSet: 7
Gerrit-Owner: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.corp-partner.google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Reviewer: Yuval Peress
peress@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Attention: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.corp-partner.google.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Tue, 19 Mar 2024 18:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tanu Malhotra
tanu.malhotra@intel.com
Comment-In-Reply-To: Li1 Feng
li1.feng@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment