Attention is currently required from: Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 17:
(363 comments)
File util/coreboot-configurator/src/Documentation.txt:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/376f2b40_9aef7ef6 PS17, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'?
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f931a053_2c133584 PS17, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/74589d23_7dc04bfa PS17, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a6eed756_949b168c PS17, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/dbe15a52_3818187d PS17, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2402c964_86fc6a3f PS17, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c2c3b345_3f2ac576 PS17, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2c9975be_32beceba PS17, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/da733590_eee31c7b PS17, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/89d61568_06b14ed0 PS17, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/62769c00_41a8fe73 PS17, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1bc2a894_556238ba PS17, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4299a2b2_dce4e058 PS17, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/183a7ce7_225026c1 PS17, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fefaec30_8e03841e PS17, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c76498c7_d068dc55 PS17, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e5e735f0_cbdf22c8 PS17, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/14f71b5c_9dffea0a PS17, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b49e11a3_0d6709ca PS17, Line 37: void showEvent(QShowEvent *ev); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/da778496_586326c4 PS17, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b6cdb72a_fc93061a PS17, Line 38: void closeEvent(QCloseEvent *ev); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0095f689_76d91a5e PS17, Line 42: void closeWindow(int result); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/052020b4_74e19574 PS17, Line 43: void saveAndClose(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1f7039bc_8c3b52c5 PS17, Line 46: void getSettings(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1c3b4692_ec236001 PS17, Line 47: void getFromFile(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/35eebe8f_4df9a34f PS17, Line 48: void displaySettings(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6ba33467_166e6560 PS17, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ced4c179_49b79288 PS17, Line 51: void writeSettings(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cc344570_13e5c38f PS17, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/993d05ac_8c51a21e PS17, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1f212068_7204c93e PS17, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8b9a49e3_c708e474 PS17, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/576e0478_17b3bd31 PS17, Line 59: QString m_fileName; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/40674d70_24db1aaf PS17, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2c4f1b82_eeeddb35 PS17, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/56808026_bb4ffe8d PS17, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/29807035_a85be9ff PS17, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7a8f7546_d8aac578 PS17, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/91e10193_e5533100 PS17, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/05d1f431_947c7317 PS17, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c0ed2721_924d9e9b PS17, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/98616e34_805d5fc6 PS17, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/087ef333_5d0382cb PS17, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1e045c44_9e675d61 PS17, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3d41ea98_964cd789 PS17, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fd71412f_6a8653c1 PS17, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7aff3115_db16dcab PS17, Line 30: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b87e70c1_dee8533e PS17, Line 30: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e2908213_9e018cbf PS17, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/229e5725_b5bbdee5 PS17, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3d949064_21a7e949 PS17, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b302b4e1_6cc2dc0a PS17, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/506ae53a_2e065733 PS17, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e469b129_161c5f27 PS17, Line 34: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/dddc7c29_b55d2ff8 PS17, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/70a80c4b_e7130789 PS17, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/59f0d051_a714508d PS17, Line 36: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/85d77b5b_e962c7ff PS17, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8dec33bb_407eb561 PS17, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cfe054ca_0c7f0156 PS17, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/27625da2_f42f5554 PS17, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ca37cf47_136fbc57 PS17, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4daed6e2_ad8da58f PS17, Line 40: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/db9f94c5_057fc9ed PS17, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f2ae67e1_751edee1 PS17, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bfc97adb_22a4afac PS17, Line 41: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/852d1669_b0687df9 PS17, Line 41: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/403d9614_5b01f946 PS17, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d0acd101_59c0439d PS17, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/72f0cf49_c8bf1fe0 PS17, Line 43: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ce3467db_5a9fb6b6 PS17, Line 43: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/41a88a87_a884d5b9 PS17, Line 44: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3a773c85_985d6d99 PS17, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bdd31793_8dea0dcf PS17, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9aeced3c_8ed1ea29 PS17, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d3935873_ffdd4cc0 PS17, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/312a66eb_0f085e07 PS17, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/73b23b98_7436c371 PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bac637ac_5e10be7b PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b12c16ad_836dc037 PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/59a68e42_4e4f6ada PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/eb1a14e2_e6a967e4 PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/42a2abdd_43c1725a PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f9676f28_b6aae740 PS17, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ba704ce8_71341d3c PS17, Line 52: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e9718967_dc9cb1a2 PS17, Line 53: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3525ce9a_41617173 PS17, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/032878df_e9ca508d PS17, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/12405656_c4911dd9 PS17, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2893f016_b12a0c2e PS17, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f6b834f2_eda0228b PS17, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e4b926d9_06888743 PS17, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0fccea69_0de17b85 PS17, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b3a169e2_e289108f PS17, Line 56: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bcf584c0_1f613cb9 PS17, Line 56: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7e616098_44b091c4 PS17, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e512d874_c40d0084 PS17, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/89d7dd23_b9e56508 PS17, Line 58: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9eb1feb4_41ccbc5f PS17, Line 58: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/160dffe6_02800eff PS17, Line 59: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3b59a3a5_4d59b370 PS17, Line 59: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/eaa3578a_7af98f53 PS17, Line 60: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8ec02a6a_e115efc2 PS17, Line 60: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/147c5bdf_f2f5b3e0 PS17, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8abb0dc3_5cb172e2 PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/823f3cdb_a2c737ae PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ae6b6e49_ab00fb01 PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b0630fe3_f790bccb PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fcf469f1_e5f0cad4 PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9e83532a_5e7931ec PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cfef95a7_b434791f PS17, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/88cb33f1_5ce02803 PS17, Line 64: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/15f0c565_e85cd246 PS17, Line 65: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/78f30859_cdb0665a PS17, Line 65: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bf6ebb93_aae317ed PS17, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2ef559ad_44584294 PS17, Line 66: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1deab9f3_8d01f380 PS17, Line 66: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fa17ac8e_d79834f4 PS17, Line 68: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/52483f4d_3ff469ae PS17, Line 68: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/838ccf0a_8b9d37cb PS17, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/395b3bd4_cced058f PS17, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/64f00323_54b8a0f3 PS17, Line 70: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/acbad4a9_d9b40f54 PS17, Line 70: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f55a5297_179ea693 PS17, Line 70: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/57a5d100_79016feb PS17, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/41eace56_5c3b1424 PS17, Line 71: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c4ef5499_b947427f PS17, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e28f9bf6_8bc95d5e PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/193e3574_b9588ccb PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/58334569_dc8c91f6 PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fe973961_31359904 PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3e5c4ea9_9b2dee94 PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7cee221b_63807b03 PS17, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ea46bf18_34d85392 PS17, Line 73: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/5f29125f_44e168e5 PS17, Line 73: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fc1571eb_e6d7b750 PS17, Line 74: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fe520c8a_4ca61ce7 PS17, Line 74: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0e602cb7_27617316 PS17, Line 75: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a2d93870_bfd26c2f PS17, Line 75: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0af48cd5_bee2d2cf PS17, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6da9b02f_4ebcdcdf PS17, Line 80: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7f6b1e61_a1190db2 PS17, Line 80: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f9685bc0_6227b4af PS17, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3ba72824_fd8aa05b PS17, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d9a3549d_ad43996e PS17, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ea1c3e52_3bc975b3 PS17, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/66f3e165_b4ca8649 PS17, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c5b99e07_15ed3c16 PS17, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b0893783_17b5eb3c PS17, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/00b70a0f_5e5c4864 PS17, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/460d2dff_601ae66e PS17, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7977abe8_3b8c6078 PS17, Line 84: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6b87e042_e22147b8 PS17, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3eaeae06_8e2b2310 PS17, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/5e7f9f35_b27ecfa9 PS17, Line 86: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e896c607_147cb2e3 PS17, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/049e5880_4de1bb3c PS17, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/97c9e7f2_1bd7c4f0 PS17, Line 87: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3ae4bf15_df9f8ac1 PS17, Line 87: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ddd685e1_836656ce PS17, Line 88: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/09011248_5b62c59d PS17, Line 88: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/03d6773f_5b281947 PS17, Line 89: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2b2df1fe_fc29196f PS17, Line 89: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2b2af1b7_b197bf4d PS17, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8c5db439_d7c61f94 PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1aed2938_fcc9edfe PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/03129a6c_e1eb1080 PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8803794d_6730f7be PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/172fa2d8_d5f20267 PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/16172231_c118d694 PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d655d312_fd254605 PS17, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4be19cac_d6cee545 PS17, Line 93: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6087cc58_822540a6 PS17, Line 94: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8b7140b9_71cfbd25 PS17, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/57d21cbd_abb8e52b PS17, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/39860af4_378a4aa1 PS17, Line 95: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/69d5ae1a_17339024 PS17, Line 95: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/947c2d3e_166e0a49 PS17, Line 97: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/587d5384_3e8e1fc1 PS17, Line 97: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/49951195_e731d9dc PS17, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cd9f2377_b8d45f1c PS17, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/860e25dd_8b53375b PS17, Line 99: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9f58a344_9774a289 PS17, Line 99: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1b041cd3_0939ff52 PS17, Line 99: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/35b26379_ae5c94a8 PS17, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f5e7e0cb_1d5cf427 PS17, Line 100: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/53f9a68e_bd7da15d PS17, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b6a61837_29b80a17 PS17, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1093f53a_be1d529b PS17, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/02bca8e7_6df57b67 PS17, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/64416c04_1e2de3de PS17, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/39cf0c3c_b7c15cdf PS17, Line 102: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ce3f6755_546bb8f3 PS17, Line 102: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/feb43d48_f04e290a PS17, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6306ec1d_3f0de8f6 PS17, Line 103: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9a826ccf_1fb6d0cc PS17, Line 104: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/103c3962_02d6ce41 PS17, Line 104: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/40a745a6_4d7ddeaf PS17, Line 105: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b77d06f1_4cb41891 PS17, Line 109: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3c064155_64bd4f36 PS17, Line 109: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0de79aee_ec1cbb2d PS17, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b217958c_af73393c PS17, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/71885e4a_f3cee630 PS17, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8b198b7e_0b431102 PS17, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a0b3beab_14027eb5 PS17, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0d924140_875785f6 PS17, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d204963d_604202c2 PS17, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/71a8ad33_b67539ee PS17, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/66cddf99_89921171 PS17, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/54be98e0_7fff4b8a PS17, Line 113: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/46e20e92_0a0336e9 PS17, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/955a868c_d40573a1 PS17, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9042ed90_9ca7c1ab PS17, Line 115: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/66257a28_2f6975eb PS17, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6b887be1_375441bc PS17, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e763804f_cab63a5d PS17, Line 116: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e2767015_66cfc8f2 PS17, Line 116: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/96ab872e_e90fbad3 PS17, Line 117: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cddfed02_4cab757d PS17, Line 117: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7449b146_ca3009a0 PS17, Line 118: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/97f29d61_05ad4a09 PS17, Line 118: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/faa05713_89360d7e PS17, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/39e18461_d93c8bf4 PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/05b187bc_9ea6a122 PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3c869955_eca2aacc PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/11957ee4_ef042a8e PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3c315001_63602bb1 PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9644f581_e04cae24 PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2c4d454a_0dd682d7 PS17, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ecc33505_fe998664 PS17, Line 122: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d5c7b960_989d53f7 PS17, Line 123: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6186eff9_00ff60c1 PS17, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a2b0c3cc_d285fab2 PS17, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e01e0ceb_8772b830 PS17, Line 124: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/99000f08_81c6d260 PS17, Line 124: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/79d4f960_dd8df4dc PS17, Line 126: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e5df6bea_846175e4 PS17, Line 126: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/157451a5_9828c416 PS17, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ba5836c6_fe88652f PS17, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c453c63b_7d33ccac PS17, Line 128: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6a3980b8_cde50744 PS17, Line 128: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/53b9ad60_8634df1a PS17, Line 128: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/5940407a_529e450b PS17, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/399fe327_7c764bec PS17, Line 129: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/74163152_fb31429d PS17, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d22a0af7_21a49a8a PS17, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2fad82a2_a23894fa PS17, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3acbcf3b_ac8a3ec2 PS17, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1763e06a_58fda5a4 PS17, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b67ff080_3ea9aa35 PS17, Line 131: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/11b542f2_34d046f6 PS17, Line 131: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/29ef0c09_ab8a9ff1 PS17, Line 132: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1a39524e_048c455a PS17, Line 132: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ac76e860_e019de2c PS17, Line 133: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e52ab4c5_78fd99a9 PS17, Line 133: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/17e96cc3_f443e8bd PS17, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ace646a7_6ba680d5 PS17, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cfccf1bc_d8ac358c PS17, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3f867e22_9d6f9c3b PS17, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1669ee56_504057c5 PS17, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/fcc70d87_4f58bac3 PS17, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8d885158_63c4ee34 PS17, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c5bd9a56_9b29f517 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/82ae500d_950827b5 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/eb8e1f78_1a4f6113 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b1dccd36_34ed8c44 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/dabcf5c7_04dcf668 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1f4456de_bf8a5618 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/12f11b42_99a4f4d4 PS17, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f6b14808_406d6f03 PS17, Line 142: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/30b0dab6_0b984e78 PS17, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9537772c_9764b81c PS17, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/afabe097_d63ba5c8 PS17, Line 144: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/81f99079_a8e159a0 PS17, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/bcb1a4ac_824afc87 PS17, Line 145: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9810d191_85287327 PS17, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b61dd8a9_c6fda40f PS17, Line 146: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9a7f8944_edecab62 PS17, Line 146: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/99b305c0_257dfddf PS17, Line 147: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b34b9df3_18bbe6bb PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f4f1a7a2_46d40296 PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/7d10e3df_6b59ca57 PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/8ee38b8a_7ac0c69b PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/831a5fb1_bd21a852 PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a7219702_9081dd34 PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6473d8e1_71e62e76 PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6e2e8788_3340951d PS17, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/98855a80_512d33c9 PS17, Line 150: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/9c4ff2cd_530c054a PS17, Line 151: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2874865f_04f60972 PS17, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4274834c_5709116b PS17, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/04690969_714f3be6 PS17, Line 152: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/49057dd1_70649c38 PS17, Line 152: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1a80d817_982a1609 PS17, Line 153: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/2f4d05e0_dbb0fc37 PS17, Line 153: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/a40f21da_2c478520 PS17, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/30a2e5a5_28addc47 PS17, Line 154: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/690dd382_b2ecbec3 PS17, Line 154: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/04784e13_e6c08c59 PS17, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/64739469_af96b1f2 PS17, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ba507c2c_8b935959 PS17, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d085d483_179de32e PS17, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/91bfcf1d_afe4f8f9 PS17, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4ed62790_ced127ad PS17, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/77b089c8_ade8ceba PS17, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b0603cdc_e39881fe PS17, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/17c6cdd5_a4a790b4 PS17, Line 158: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/61f36559_9fbd0c88 PS17, Line 158: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/11caf865_19cd69a9 PS17, Line 159: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d6a5e668_b8174615 PS17, Line 163: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/61539a80_0440e1ba PS17, Line 163: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0caf00b4_00c962bf PS17, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6749c388_dcd41608 PS17, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/172e2b04_3ccc5ffb PS17, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e922a041_b1f5d4b3 PS17, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/541b61c0_e90341ba PS17, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/642ba76e_04371196 PS17, Line 167: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0db9276a_0c93a23a PS17, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/532390fe_64bd42c1 PS17, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cd28a42e_9def7f4f PS17, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/cc4483f9_3fcd6f18 PS17, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/07637008_6f1cc04f PS17, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/97f7bc46_4c9afecb PS17, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/5dd46ac0_588b4809 PS17, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/36cb597e_db3721cf PS17, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c85860e3_6680670a PS17, Line 170: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/491455a3_61137aa8 PS17, Line 170: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/0c2ae819_3a8388b0 PS17, Line 171: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/4048f77a_fae9d7d3 PS17, Line 171: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6ef1515e_9cd847d7 PS17, Line 172: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/51924258_d9c387b4 PS17, Line 172: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/13194b05_7a6d3afb PS17, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c70b2bb3_5aaca276 PS17, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/868cbd71_1133fe0b PS17, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d89e3075_fd87f7bc PS17, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/df6975af_afb444ad PS17, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/74dafbe6_f6c5f5fb PS17, Line 176: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/562713ac_f4876e32 PS17, Line 177: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c3853d00_27f5c52e PS17, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/3c73807d_4cfa3b31 PS17, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/6c3e46ff_72b0dc98 PS17, Line 178: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/f22b0de4_f556495a PS17, Line 178: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e887b80f_b6692c56 PS17, Line 180: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/5f209c67_bf94745f PS17, Line 180: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/002c8a02_71446dc9 PS17, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/e4210cf5_f15c26ad PS17, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/382bf65c_8f4f039e PS17, Line 182: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/d1909c41_b5cbf318 PS17, Line 182: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/83cc4312_cdcd6e6a PS17, Line 182: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/c0e214a9_61a98687 PS17, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/366f0e55_6b3c9dea PS17, Line 183: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/483a1014_e401efaa PS17, Line 183: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b1f1ebae_052bdb63 PS17, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ed9efd56_eab06cf6 PS17, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b6e3de4c_f91b1d05 PS17, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ade46e51_cb60a410 PS17, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ca986d53_218276f6 PS17, Line 185: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/65f3b20d_3192ad6a PS17, Line 185: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ef9d559f_651722f7 PS17, Line 186: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/b3039f07_6fefacc5 PS17, Line 186: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/18c67666_b41192e4 PS17, Line 187: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/ca5b7d28_036919ea PS17, Line 187: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132343): https://review.coreboot.org/c/coreboot/+/58854/comment/1a584657_fcc179fe PS17, Line 188: } please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)