Hello Joel Kitching, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37773
to review the following change.
Change subject: configs: add config.google_kevin_secdata_mock ......................................................................
configs: add config.google_kevin_secdata_mock
This patch adds a BOARD_GOOGLE_KEVIN variant config that enables CONFIG_VBOOT_MOCK_SECDATA. This is to ensure that Jenkins will build the MOCK_SECDATA-specific code at least once, to be sure we don't accidentally break it during refactoring.
Change-Id: Ib0ffaccdf4601d6bfb889ae289d1d7df18bed1fd Signed-off-by: Julius Werner jwerner@chromium.org --- A configs/config.google_kevin_secdata_mock 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/37773/1
diff --git a/configs/config.google_kevin_secdata_mock b/configs/config.google_kevin_secdata_mock new file mode 100644 index 0000000..97d6a3a --- /dev/null +++ b/configs/config.google_kevin_secdata_mock @@ -0,0 +1,5 @@ +CONFIG_VENDOR_GOOGLE=y +CONFIG_BOARD_GOOGLE_KEVIN=y +CONFIG_CHROMEOS=y +CONFIG_VBOOT_MOCK_SECDATA=y +CONFIG_PAYLOAD_NONE=y
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37773 )
Change subject: configs: add config.google_kevin_secdata_mock ......................................................................
Patch Set 1: Code-Review+2
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37773 )
Change subject: configs: add config.google_kevin_secdata_mock ......................................................................
Patch Set 1: Code-Review+2
Joel Kitching has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37773 )
Change subject: configs: add config.google_kevin_secdata_mock ......................................................................
configs: add config.google_kevin_secdata_mock
This patch adds a BOARD_GOOGLE_KEVIN variant config that enables CONFIG_VBOOT_MOCK_SECDATA. This is to ensure that Jenkins will build the MOCK_SECDATA-specific code at least once, to be sure we don't accidentally break it during refactoring.
Change-Id: Ib0ffaccdf4601d6bfb889ae289d1d7df18bed1fd Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/37773 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Joel Kitching kitching@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A configs/config.google_kevin_secdata_mock 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Joel Kitching: Looks good to me, approved
diff --git a/configs/config.google_kevin_secdata_mock b/configs/config.google_kevin_secdata_mock new file mode 100644 index 0000000..97d6a3a --- /dev/null +++ b/configs/config.google_kevin_secdata_mock @@ -0,0 +1,5 @@ +CONFIG_VENDOR_GOOGLE=y +CONFIG_BOARD_GOOGLE_KEVIN=y +CONFIG_CHROMEOS=y +CONFIG_VBOOT_MOCK_SECDATA=y +CONFIG_PAYLOAD_NONE=y
-
Furquan Shaikh (Code Review) -
Joel Kitching (Code Review)
-
Julius Werner (Code Review)