Attention is currently required from: Felix Singer, Arthur Heymans, Keith Hui, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61540 )
Change subject: mb/asus/p8x7x-series: Refactor mainboard_get_spd()
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/mainboard/asus/p8x7x-series/variants/p8c_ws/early_init.c:
https://review.coreboot.org/c/coreboot/+/61540/comment/a2cedc25_5f14ee79
PS4, Line 5: #include <northbridge/intel/sandybridge/raminit_native.h>
sounds odd to me. […]
Let's not waste any more time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61540
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b9c616a6c722e1f0fc124ced225efdcadb46b25
Gerrit-Change-Number: 61540
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 02 Mar 2023 09:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment