Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Shuo Liu.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81209?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: symbols: Add __maybe_unused flag to region variable symbols
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81209/comment/43dd3a87_86dd8657 :
PS4, Line 12: comipler
compiler
Patchset:
PS4:
Good after fixing a typo in the commit message. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81209?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5ed183b2dd7a474ce51de47dbc1f9e3f61e5a41
Gerrit-Change-Number: 81209
Gerrit-PatchSet: 4
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Sun, 17 Mar 2024 16:45:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment