Change in coreboot[master]: mb/google/poppy: auto-select correct audio blobs

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37316 )

Change subject: mb/google/poppy: auto-select correct audio blobs
......................................................................

mb/google/poppy: auto-select correct audio blobs

Auto-select the correct audio blobs needed for each variant
if INCLUDE_NHLT_BLOBS is selected. Audio is non-functional
without them, so include as appropriate.

Change-Id: Iedee3fa41a69ea1b8077bbe4bd0be278fd5c5343
Signed-off-by: Matt DeVillier 
---
M src/mainboard/google/poppy/Kconfig
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/37316/1

diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index d7808ed..590bd7f 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -142,6 +142,7 @@
    select DRIVERS_USB_ACPI
    select EXCLUDE_NATIVE_SD_INTERFACE
    select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR
+	select INCLUDE_NHLT_BLOBS_ATLAS if INCLUDE_NHLT_BLOBS
    select INTEL_GMA_HAVE_VBT
    select MAINBOARD_HAS_SPI_TPM_CR50
    select VARIANT_HAS_CAMERA_ACPI
@@ -160,6 +161,7 @@
    select DRIVERS_I2C_DA7219
    select DRIVERS_SPI_ACPI
    select EXCLUDE_NATIVE_SD_INTERFACE
+	select INCLUDE_NHLT_BLOBS_NAMI if INCLUDE_NHLT_BLOBS
    select INTEL_GMA_HAVE_VBT
    select MAINBOARD_HAS_SPI_TPM_CR50

@@ -168,6 +170,7 @@
    select CHROMEOS_WIFI_SAR if CHROMEOS
    select DRIVERS_GENERIC_MAX98357A
    select DRIVERS_I2C_DA7219
+	select INCLUDE_NHLT_BLOBS_NAUTILUS if INCLUDE_NHLT_BLOBS
    select INTEL_GMA_HAVE_VBT
    select MAINBOARD_HAS_I2C_TPM_CR50
    select VARIANT_HAS_CAMERA_ACPI
@@ -182,6 +185,7 @@
    select DRIVERS_USB_ACPI
    select EXCLUDE_NATIVE_SD_INTERFACE
    select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR
+	select INCLUDE_NHLT_BLOBS_NOCTURNE if INCLUDE_NHLT_BLOBS
    select INTEL_GMA_HAVE_VBT
    select MAINBOARD_HAS_SPI_TPM_CR50
    select NO_FADT_8042
@@ -194,6 +198,7 @@
    select DRIVERS_I2C_DA7219
    select DRIVERS_SPI_ACPI
    select DRIVERS_USB_ACPI
+	select INCLUDE_NHLT_BLOBS_RAMMUS if INCLUDE_NHLT_BLOBS
    select INTEL_GMA_HAVE_VBT
    select MAINBOARD_HAS_LIBGFXINIT
    select MAINBOARD_HAS_SPI_TPM_CR50

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37316 )

Change subject: mb/google/poppy: auto-select correct audio blobs
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37316/1/src/mainboard/google/poppy/... 
File src/mainboard/google/poppy/Kconfig:

https://review.coreboot.org/c/coreboot/+/37316/1/src/mainboard/google/poppy/... 
PS1, Line 49: config INCLUDE_NHLT_BLOBS
Is this really to be selected along with one of the other options? It
looks a little as if it were either this or one of the others.

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37316 )

Change subject: mb/google/poppy: auto-select correct audio blobs
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37316/1/src/mainboard/google/poppy/... 
File src/mainboard/google/poppy/Kconfig:

https://review.coreboot.org/c/coreboot/+/37316/1/src/mainboard/google/poppy/... 
PS1, Line 49: config INCLUDE_NHLT_BLOBS
> Is this really to be selected along with one of the other options? It […]

you appear to be correct - I was confusing this with the SKL/glados implementation where it was a base + variant setup. will abandon

[Matt DeVillier (Code Review)]

Matt DeVillier has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37316 )

Change subject: mb/google/poppy: auto-select correct audio blobs
......................................................................

Abandoned