Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29950 )
Change subject: soc/qualcomm/qcs405: Add MMU support ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/#/c/29950/13/src/soc/qualcomm/qcs405/include/soc... File src/soc/qualcomm/qcs405/include/soc/symbols.h:
https://review.coreboot.org/#/c/29950/13/src/soc/qualcomm/qcs405/include/soc... PS13, Line 23: #define _ssram_size (_essram - _ssram) This pattern has recently been replaced, please use DECLARE_REGION() (from <symbols.h>) now.
https://review.coreboot.org/#/c/29950/13/src/soc/qualcomm/qcs405/mmu.c File src/soc/qualcomm/qcs405/mmu.c:
https://review.coreboot.org/#/c/29950/13/src/soc/qualcomm/qcs405/mmu.c@28 PS13, Line 28: _ssram_size ...and then this will become REGION_SIZE(ssram)
-
Julius Werner (Code Review)