Attention is currently required from: Julius Werner.
Kapil Porwal has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/86030?usp=email )
Change subject: commonlib/dt: Fix incorrect cell properties ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The previous patch failed the CQ while building DC. Refer https://crrev/c/6178415 […]
We need this patch. Consider below example -
Input node: /abc
PASS#1: Parent="/" Path="abc", '/0' Cell Properties: From parent i.e. "/" Path[0] is not NULL so proceed with recursion.
PASS#2: Parent="/abc" Path='/0' Cell Properties: From parent i.e. "/abc" Path[0] is NULL so break from recursion.
If we exit from PASS#2 without returning cell properties of current parent (i.e. "/abc") the cell properties would contain values from PASS#1 which is not correct.
Please let me know if I am missing anything.