Pavel Kovalenko has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 9:
Thanks for the explanation. Now I understand also the bug which I have with the display.
My lid does not trigger suspend (I configured it this way). So when my lid is closed, the EN line must be low, but the display is on full brightness. I will try to desolder the sense pin.
@nitrocaster I could imagine the firmware of the STM8 is not much. Do you thought about open sourcing it?
There's also a compatibility mode which should disable any 'smart' logic inside STM8, making it a dumb translator. You can activate it by shorting OPT1 and OPT2 pads as shown here: https://nitrocaster.me/files/compat_mode.png
The firmware I would be happy to make public too, but it looks so disgusting that I don't feel comfortable sharing it right now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 9
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aleksei Kharlamov
derlafff@ya.ru
Gerrit-CC: Christian Herzog
Gerrit-CC: Holger Levsen
holger@layer-acht.org
Gerrit-CC: Kilian Neuner
cb@9-r.net
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Pavel Kovalenko
su@nitrocaster.me
Gerrit-CC: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-CC: Tom Hiller
thrilleratplay@gmail.com
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-Comment-Date: Sun, 22 Dec 2019 10:56:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment