Change in coreboot[master]: mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad

[Tim Chen (Code Review)]

Hello Tim Chen,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/47441

to review the following change.

Change subject: mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad
......................................................................

mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad

Add Elan and Synaptics touchpad settings.

BUG=b:169813211
BRANCH=None
TEST=build metaknight firmware

Change-Id: Ice0a86cd5610db269d44acb1d51cb652110d9b0c
Signed-off-by: Tim Chen 
---
M src/mainboard/google/dedede/variants/metaknight/overridetree.cb
1 file changed, 19 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/47441/1

diff --git a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
index 73ef0b8..8eb9570 100644
--- a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
@@ -43,7 +43,25 @@
    }"

device domain 0 on
-		device pci 15.0 on end
+		device pci 15.0 on
+			chip drivers/i2c/hid
+				register "generic.hid" = ""PNP0C50""
+				register "generic.desc" = ""Synaptics Touchpad""
+				register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_B3_IRQ)"
+				register "generic.wake" = "GPE0_DW0_03"
+				register "generic.probed" = "1"
+				register "hid_desc_reg_offset" = "0x20"
+				device i2c 0x2c on end
+			end
+			chip drivers/i2c/generic
+				register "hid" = ""ELAN0000""
+				register "desc" = ""ELAN Touchpad""
+				register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)"
+				register "wake" = "GPE0_DW0_03"
+				register "probed" = "1"
+				device i2c 15 on end
+			end
+		end # I2C 0
    	device pci 15.2 on
    		chip drivers/i2c/hid
    			register "generic.hid" = ""GDIX0000""

[Tim Chen (Code Review)]

Tim Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47441 )

Change subject: mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47441/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/metaknight/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47441/1/src/mainboard/google/dedede... 
PS1, Line 59: ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)
I had tried with the same setting with waddledoo and magolor it can wake system up successfully.

[Raymond Wong (Code Review)]

Raymond Wong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47441 )

Change subject: mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad
......................................................................

Patch Set 1:

Hi Tim, can you look at the merge conflict. Thanks.

[Tim Chen (Code Review)]

Hello build bot (Jenkins), Henry Sun, Tim Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47441

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad
......................................................................

mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad

Add Elan and Synaptics touchpad settings.

BUG=b:169813211
BRANCH=None
TEST=build metaknight firmware

Change-Id: Ice0a86cd5610db269d44acb1d51cb652110d9b0c
Signed-off-by: Tim Chen 
---
M src/mainboard/google/dedede/variants/metaknight/overridetree.cb
1 file changed, 19 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/47441/2

[Tim Chen (Code Review)]

Tim Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47441 )

Change subject: mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad
......................................................................

Patch Set 2:
> Patch Set 1:
>
> Hi Tim, can you look at the merge conflict. Thanks.

Done. Could you help to review again? Thanks.

[Raymond Wong (Code Review)]

Raymond Wong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47441 )

Change subject: mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad
......................................................................

Patch Set 2: Code-Review+1

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47441 )

Change subject: mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/47441/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/metaknight/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47441/1/src/mainboard/google/dedede... 
PS1, Line 59: ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)
> I had tried with the same setting with waddledoo and magolor it can wake system up successfully.

Ack

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47441 )

Change subject: mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad
......................................................................

mb/google/dedede/var/metaknight: Support Elan/Synaptics touchpad

Add Elan and Synaptics touchpad settings.

BUG=b:169813211
BRANCH=None
TEST=build metaknight firmware

Change-Id: Ice0a86cd5610db269d44acb1d51cb652110d9b0c
Signed-off-by: Tim Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47441
Tested-by: build bot (Jenkins) 
Reviewed-by: Raymond Wong 
Reviewed-by: Karthik Ramasubramanian 
---
M src/mainboard/google/dedede/variants/metaknight/overridetree.cb
1 file changed, 19 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Karthik Ramasubramanian: Looks good to me, approved
  Raymond Wong: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
index 000182ec..7034f5c 100644
--- a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
@@ -63,7 +63,25 @@
    			end
    		end
    	end # USB xHCI
-		device pci 15.0 on end
+		device pci 15.0 on
+			chip drivers/i2c/hid
+				register "generic.hid" = ""PNP0C50""
+				register "generic.desc" = ""Synaptics Touchpad""
+				register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_B3_IRQ)"
+				register "generic.wake" = "GPE0_DW0_03"
+				register "generic.probed" = "1"
+				register "hid_desc_reg_offset" = "0x20"
+				device i2c 0x2c on end
+			end
+			chip drivers/i2c/generic
+				register "hid" = ""ELAN0000""
+				register "desc" = ""ELAN Touchpad""
+				register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)"
+				register "wake" = "GPE0_DW0_03"
+				register "probed" = "1"
+				device i2c 15 on end
+			end
+		end # I2C 0
    	device pci 15.2 on
    		chip drivers/i2c/hid
    			register "generic.hid" = ""GDIX0000""