[M] Change in coreboot[master]: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347

[Nicholas Chin (Code Review)]

Attention is currently required from: Angel Pons, Kyösti Mälkki.

Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68264 )

Change subject: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347
......................................................................

Patch Set 4:

(1 comment)

File src/drivers/usb/gadget.c:

https://review.coreboot.org/c/coreboot/+/68264/comment/f628f5c8_d70ae139 
PS4, Line 215: } __packed;
> Are you conserned of endianess or sizeof() or something else?

I guess what matters here is that those fields are in that order in a contiguous 7 byte area, and that the byte order is the same as what the USB CDC protocol expects. I'm assuming the EHCI debug stack just sends out whatever bytes it receives in the order they are received, and looking at a Wireshark dump of the USB CDC packet it appears that the 32-bit baud rate is sent LSB so I guess endianness could be an issue.