Attention is currently required from: Hung-Te Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers ......................................................................
Patch Set 6:
(9 comments)
File src/soc/mediatek/mt8186/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136263): https://review.coreboot.org/c/coreboot/+/60317/comment/462a2a74_7c598d8b PS6, Line 70: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136263): https://review.coreboot.org/c/coreboot/+/60317/comment/1a65fcfa_626dcf3c PS6, Line 75: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136263): https://review.coreboot.org/c/coreboot/+/60317/comment/5a4918a3_6d2513ef PS6, Line 83: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136263): https://review.coreboot.org/c/coreboot/+/60317/comment/420b1865_8650241c PS6, Line 97: #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136263): https://review.coreboot.org/c/coreboot/+/60317/comment/bc2a2b72_3c8fdf93 PS6, Line 98: #define FORBIDDEN4 FORBIDDEN3, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136263): https://review.coreboot.org/c/coreboot/+/60317/comment/719b6c64_a3ca554a PS6, Line 99: #define FORBIDDEN5 FORBIDDEN4, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136263): https://review.coreboot.org/c/coreboot/+/60317/comment/3bd2f838_5babbe13 PS6, Line 100: #define FORBIDDEN6 FORBIDDEN5, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136263): https://review.coreboot.org/c/coreboot/+/60317/comment/66dc42b7_7b89d884 PS6, Line 101: #define FORBIDDEN7 FORBIDDEN6, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136263): https://review.coreboot.org/c/coreboot/+/60317/comment/18662c23_76e7b3c8 PS6, Line 103: #define NO_PROTECTION4 NO_PROTECTION, NO_PROTECTION, NO_PROTECTION, NO_PROTECTION Macros with complex values should be enclosed in parentheses
-
build bot (Jenkins) (Code Review)