Change in coreboot[master]: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48750 )
Change subject: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI ......................................................................
Patch Set 38: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/48750/36/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48750/36/src/mainboard/clevo/cml-u/... PS36, Line 69: 0x400
@Nico is that right? […]
Sounds good. It's also what I used last time.
https://review.coreboot.org/c/coreboot/+/48750/38/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48750/38/src/mainboard/clevo/cml-u/... PS38, Line 69: { .ndid = 1, .did = { 0x400 } } We could add another macro for this, e.g. `GMA_DEFAULT_PANEL`.
-
Nico Huber (Code Review)