[XS] Change in coreboot[main]: Makefile.inc: Enable Wold-style-declaration command option

[Felix Singer (Code Review)]

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71892?usp=email )

Change subject: Makefile.inc: Enable Wold-style-declaration command option
......................................................................

Makefile.inc: Enable Wold-style-declaration command option

Warn for obsolescent usages, according to the C Standard, in a
declaration. For example, warn if storage-class specifiers like static
are not the first things in a declaration.

Change-Id: Ida3fa59edb07e4105ef3cfb6a20cb29680699586
Signed-off-by: Elyes Haouas 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71892
Reviewed-by: Martin L Roth 
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Singer 
---
M Makefile.inc
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Martin L Roth: Looks good to me, approved
  build bot (Jenkins): Verified
  Felix Singer: Looks good to me, approved

diff --git a/Makefile.inc b/Makefile.inc
index 44cd0ea..23f56a4 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -498,6 +498,7 @@
 CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer
 CFLAGS_common += -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie
 ifeq ($(CONFIG_COMPILER_GCC),y)
+CFLAGS_common += -Wold-style-declaration
 # Don't add these GCC specific flags when running scan-build
 ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),)
 CFLAGS_common += -Wno-packed-not-aligned