Attention is currently required from: Bao Zheng, Martin Roth, Marshall Dawson, Richard Spiegel, Zheng Bao, Matt Papageorge.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58871 )
Change subject: amdfwtool: Call the set_efs_table for Stoneyridge
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58871/comment/8795eedd_d1c9c313
PS3, Line 136: OPT_EFS_SPI_MICRON_FLAG=$(call add_opt_prefix, $(CONFIG_EFS_SPI_MICRON_FLAG), --spi-micron-flag)
i don't see the micron flag in the documentation for the pre-zen socs, so it's probably not needed to pass that parameter
https://review.coreboot.org/c/coreboot/+/58871/comment/fe0a842e_3992bd7d
PS3, Line 155: $(OPT_EFS_SPI_MICRON_FLAG) \
same comment as above
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24499ff6daf7878b12b6044496f53379116c598f
Gerrit-Change-Number: 58871
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Comment-Date: Thu, 04 Nov 2021 01:37:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment