Furquan Shaikh (furquan@google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16242
-gerrit
commit 52e5fa70a21c16da5a50eb33679c72ab5390e9b7 Author: Furquan Shaikh furquan@google.com Date: Wed Aug 17 16:16:39 2016 -0700
intel/apollolake: Skip ITSS configuration in SMM
In SMM, gpio configuration could be done to avoid leakage. ITSS configuration is not required when entering sleep. Thus, bail out early from itss configuration if in SMM.
BUG=chrome-os-partner:56281
Change-Id: I4d8be0513aa202f001f980bb91986b50b8ed2a5b Signed-off-by: Furquan Shaikh furquan@google.com --- src/soc/intel/apollolake/gpio.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/src/soc/intel/apollolake/gpio.c b/src/soc/intel/apollolake/gpio.c index 8b89dfd..8e4ff3e 100644 --- a/src/soc/intel/apollolake/gpio.c +++ b/src/soc/intel/apollolake/gpio.c @@ -72,6 +72,10 @@ static const struct pad_community *gpio_get_community(uint16_t pad) static void gpio_configure_itss(const struct pad_config *cfg, uint16_t port, uint16_t pad_cfg_offset) { + /* No ITSS configuration in SMM. */ + if (ENV_SMM) + return; + int irq;
/* Set up ITSS polarity if pad is routed to APIC.