Change in coreboot[master]: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support

[Cliff Huang (Code Review)]

Attention is currently required from: Bora Guvendik, Anil Kumar K, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Thejaswani Putta.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61354 )

Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support
......................................................................

Patch Set 8:

(2 comments)

File src/drivers/wwan/fm/acpi_fm350gl.c:

https://review.coreboot.org/c/coreboot/+/61354/comment/045f46f0_4b6ac677 
PS7, Line 64: /* warm reset */
            : 	acpigen_write_if_lequal_op_int(ARG0_OP, 0);
            : 	acpigen_write_sleep(FM350GL_TBTG);
            : 	/* cold reset */
            : 	acpigen_write_else();
            : 	acpigen_write_if_lequal_op_int(ARG0_OP, 1);
> suggestion: […]

okay. Let me change to this.

https://review.coreboot.org/c/coreboot/+/61354/comment/7344f1db_bdb27e5a 
PS7, Line 52: acpigen_write_method_serialized("FHRF", 1);
            : 	/* LOCAL0 = PERST# */
            : 	acpigen_get_tx_gpio(&config->perst_gpio);
            : 	acpigen_write_if_lequal_op_int(LOCAL0_OP, 0);
            : 	if (wwan_fm350gl_get_rtd3_method_support(config) | ACPI_PCIE_RP_EMIT_L23)
            : 		acpigen_emit_namestring(acpi_device_path_join(parent_dev, "DL23"));
            : 	/* assert PERST# pin */
            : 	acpigen_enable_tx_gpio(&config->perst_gpio);
            : 	acpigen_write_if_end(); /* If */
            : 	acpigen_write_sleep(FM350GL_TR2B);
            : 	/* assert RESET# pin */
            : 	acpigen_enable_tx_gpio(&config->reset_gpio);
            : 	/* warm reset */
            : 	acpigen_write_if_lequal_op_int(ARG0_OP, 0);
            : 	acpigen_write_sleep(FM350GL_TBTG);
            : 	/* cold reset */
            : 	acpigen_write_else();
            : 	acpigen_write_if_lequal_op_int(ARG0_OP, 1);
            : 	/* disable source clock */
            : 	if (wwan_fm350gl_get_rtd3_method_support(config) | ACPI_PCIE_RP_EMIT_SRCK)
            : 		acpigen_emit_namestring(acpi_device_path_join(parent_dev, "SRCK"));
            : 	acpigen_emit_byte(ZERO_OP);
            : 	acpigen_write_sleep(FM350GL_TB2F);
            : 	/* assert FCPO# pin */
            : 	acpigen_enable_tx_gpio(&config->fcpo_gpio);
            : 	acpigen_write_sleep(FM350GL_TFDI);
            : 	acpigen_write_if_end(); /* If */
            : 	acpigen_pop_len(); /* Else */
            : 	acpigen_write_method_end(); /* Method */
            : }
> suggestion: […]

Good. I thought about the same thing, but I decided to follow the existing code. I can make this change.