Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40023 )
Change subject: mb/volteer: enable Early Command Training
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40023/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40023/5//COMMIT_MSG@11
PS5, Line 11: ECT enabled.
This is enabled on all platforms, we had temporarily disabled it until MRC matures. […]
Thanks, but that is not what the commit message says. It says “FSP 2527 requires” this. You answered, that it was disabled due to a bug with MRC stuff. (What is MRC in regards to FSP? I only know the term *Memory Reference Code* which was used for Google Chromebooks before FSP was introduced.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I674c30f4dfc1af6c0c4a460d66684545a190caf3
Gerrit-Change-Number: 40023
Gerrit-PatchSet: 6
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 05 Apr 2020 08:16:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-MessageType: comment