Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33003
Change subject: drivers/intel/fsp2_0: Dont' use CAR_GLOBAL ......................................................................
drivers/intel/fsp2_0: Dont' use CAR_GLOBAL
All platforms using this code have NO_CAR_GLOBAL_MIGRATION.
Change-Id: Ic50b16916261abb8c63b8fe571819af5c830ff8d Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33003/1
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index c5c78ca..95b80200 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -10,7 +10,6 @@ * (at your option) any later version. */
-#include <arch/early_variables.h> #include <device/mmio.h> #include <cbmem.h> #include <commonlib/helpers.h> @@ -100,7 +99,7 @@ * Utilities for locating and identifying HOBs */
-static void *fsp_hob_list_ptr CAR_GLOBAL; +static void *fsp_hob_list_ptr;
static void save_hob_list(int is_recovery) { @@ -122,14 +121,14 @@ uint32_t *list_loc;
if (ENV_ROMSTAGE) - return (void *)car_get_var(fsp_hob_list_ptr); + return fsp_hob_list_ptr; list_loc = cbmem_find(CBMEM_ID_FSP_RUNTIME); return (list_loc) ? (void *)(uintptr_t)(*list_loc) : NULL; }
void *fsp_get_hob_list_ptr(void) { - return car_get_var_ptr(&fsp_hob_list_ptr); + return &fsp_hob_list_ptr; }
static const
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33003 )
Change subject: drivers/intel/fsp2_0: Dont' use CAR_GLOBAL ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33003 )
Change subject: drivers/intel/fsp2_0: Dont' use CAR_GLOBAL ......................................................................
drivers/intel/fsp2_0: Dont' use CAR_GLOBAL
All platforms using this code have NO_CAR_GLOBAL_MIGRATION.
Change-Id: Ic50b16916261abb8c63b8fe571819af5c830ff8d Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/33003 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 3 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index c5c78ca..95b80200 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -10,7 +10,6 @@ * (at your option) any later version. */
-#include <arch/early_variables.h> #include <device/mmio.h> #include <cbmem.h> #include <commonlib/helpers.h> @@ -100,7 +99,7 @@ * Utilities for locating and identifying HOBs */
-static void *fsp_hob_list_ptr CAR_GLOBAL; +static void *fsp_hob_list_ptr;
static void save_hob_list(int is_recovery) { @@ -122,14 +121,14 @@ uint32_t *list_loc;
if (ENV_ROMSTAGE) - return (void *)car_get_var(fsp_hob_list_ptr); + return fsp_hob_list_ptr; list_loc = cbmem_find(CBMEM_ID_FSP_RUNTIME); return (list_loc) ? (void *)(uintptr_t)(*list_loc) : NULL; }
void *fsp_get_hob_list_ptr(void) { - return car_get_var_ptr(&fsp_hob_list_ptr); + return &fsp_hob_list_ptr; }
static const
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)