Attention is currently required from: Subrata Banik, Paul Menzel, Tim Wawrzynczak. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63294 )
Change subject: mb/google/{brya, brask}: Disable PCH USB2 phy power gating ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63294/comment/d23adc5e_1b8bff0f PS4, Line 9: The patch disables PCH USB2 Phy power gating. This change is required : to prevent possible display flicker issue.
Shorter: […]
Ack
https://review.coreboot.org/c/coreboot/+/63294/comment/6073c5fb_57d092ca PS4, Line 10: to prevent possible display flicker issue
“possible” means it was never reproduced in practice and is theoretical, or it happens sometimes, an […]
Correct, theoretical possibility and we have noticed the issue from few boards!
File src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/63294/comment/c4abefa8_b1dcf808 PS4, Line 25: # Disable PCH USB2 Phy power gating
I see all the other entries have comments, but in this case the variable names are self-describing, […]
Ack
-
Sridhar Siricilla (Code Review)