Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55735 )
Change subject: mb/google/brya: add generic LPDDR4 SPDs for Gimble ......................................................................
mb/google/brya: add generic LPDDR4 SPDs for Gimble
Add Makefile.inc to include three generic LPDDR4 SPDs for the following parts for Gimble:
DRAM Part Name DRAM ID to assign MT53E512M32D2NP-046 WT:E 0 (0000) H9HCNNNCPMMLXR-NEE 1 (0001) H9HCNNNBKMMLXR-NEE 0 (0000)
BUG=b:191574298 TEST=USE="project_gimble emerge-brya coreboot" and verify it builds without error.
Signed-off-by: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Change-Id: I60f95ac5ed7f3134882f6580335ec33632676796 Reviewed-on: https://review.coreboot.org/c/coreboot/+/55735 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/brya/variants/gimble/memory/Makefile.inc M src/mainboard/google/brya/variants/gimble/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/gimble/memory/mem_list_variant.txt D src/mainboard/google/brya/variants/gimble/memory/mem_parts_used.txt 4 files changed, 9 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved Mark Hsieh: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brya/variants/gimble/memory/Makefile.inc b/src/mainboard/google/brya/variants/gimble/memory/Makefile.inc index b0ca222..4f31da9 100644 --- a/src/mainboard/google/brya/variants/gimble/memory/Makefile.inc +++ b/src/mainboard/google/brya/variants/gimble/memory/Makefile.inc @@ -1,5 +1,6 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE +SPD_SOURCES += lp4x-spd-3.hex # ID = 1(0b0001) Parts = H9HCNNNCPMMLXR-NEE diff --git a/src/mainboard/google/brya/variants/gimble/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/gimble/memory/dram_id.generated.txt index fa24790..8a6d608 100644 --- a/src/mainboard/google/brya/variants/gimble/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/gimble/memory/dram_id.generated.txt @@ -1 +1,4 @@ DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +H9HCNNNCPMMLXR-NEE 1 (0001) +H9HCNNNBKMMLXR-NEE 0 (0000) diff --git a/src/mainboard/google/brya/variants/gimble/memory/mem_list_variant.txt b/src/mainboard/google/brya/variants/gimble/memory/mem_list_variant.txt new file mode 100644 index 0000000..5fd11c6 --- /dev/null +++ b/src/mainboard/google/brya/variants/gimble/memory/mem_list_variant.txt @@ -0,0 +1,3 @@ +MT53E512M32D2NP-046 WT:E +H9HCNNNCPMMLXR-NEE +H9HCNNNBKMMLXR-NEE diff --git a/src/mainboard/google/brya/variants/gimble/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/gimble/memory/mem_parts_used.txt deleted file mode 100644 index 9cff262..0000000 --- a/src/mainboard/google/brya/variants/gimble/memory/mem_parts_used.txt +++ /dev/null @@ -1,11 +0,0 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# One part per line with an optional fixed ID in column 2. -# Only include a fixed ID if it is required for legacy reasons! -# Generated IDs are dependent on the order of parts in this file, -# so new parts must always be added at the end of the file! -# -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/lp4x. -# See util/spd_tools/lp4x/README.md for more details and instructions. - -# Part Name
-
Nick Vaccaro (Code Review)