Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42509 )
Change subject: mb/prodrive/hermes: Disable xDCI ......................................................................
mb/prodrive/hermes: Disable xDCI
The PCI devices is used for debugging only and as Windows 10 has no default driver for it, disable it to not scare endusers about "missing" drivers.
Change-Id: I0b42a9b55f00826c5920c1c259b38382bdcdde72 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/prodrive/hermes/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42509/1
diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb index 45bd422..37f2eb7 100644 --- a/src/mainboard/prodrive/hermes/devicetree.cb +++ b/src/mainboard/prodrive/hermes/devicetree.cb @@ -21,7 +21,7 @@ device pci 08.0 on end # Gaussian Mixture device pci 12.0 on end # Thermal Subsystem device pci 14.0 on end # USB xHCI - device pci 14.1 on end # USB xDCI (OTG) + device pci 14.1 off end # USB xDCI (OTG) device pci 14.2 on end # RAM controller device pci 14.5 off end # SDCard
Hello wouter.eckhardt@prodrive-technologies.com, Philipp Deppenwiese, Justin van Son, Christian Walter, Stef van Os,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42509
to look at the new patch set (#2).
Change subject: mb/prodrive/hermes: Disable xDCI ......................................................................
mb/prodrive/hermes: Disable xDCI
The PCI devices is used for debugging only and as Windows 10 has no default driver for it, disable it to not scare endusers about "missing" drivers.
Change-Id: I0b42a9b55f00826c5920c1c259b38382bdcdde72 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/prodrive/hermes/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42509/2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42509 )
Change subject: mb/prodrive/hermes: Disable xDCI ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42509 )
Change subject: mb/prodrive/hermes: Disable xDCI ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42509/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42509/2//COMMIT_MSG@9 PS2, Line 9: devices device
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42509 )
Change subject: mb/prodrive/hermes: Disable xDCI ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42509/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42509/2//COMMIT_MSG@10 PS2, Line 10: endusers end users
Hello wouter.eckhardt@prodrive-technologies.com, Philipp Deppenwiese, build bot (Jenkins), Justin van Son, Paul Menzel, Christian Walter, Angel Pons, Stef van Os,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42509
to look at the new patch set (#3).
Change subject: mb/prodrive/hermes: Disable xDCI ......................................................................
mb/prodrive/hermes: Disable xDCI
The PCI device is used for debugging only and as Windows 10 has no default driver for it, disable it to not scare end users about "missing" drivers.
Change-Id: I0b42a9b55f00826c5920c1c259b38382bdcdde72 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/prodrive/hermes/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42509/3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42509 )
Change subject: mb/prodrive/hermes: Disable xDCI ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42509/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42509/2//COMMIT_MSG@9 PS2, Line 9: devices
device
Done
https://review.coreboot.org/c/coreboot/+/42509/2//COMMIT_MSG@10 PS2, Line 10: endusers
end users
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42509 )
Change subject: mb/prodrive/hermes: Disable xDCI ......................................................................
mb/prodrive/hermes: Disable xDCI
The PCI device is used for debugging only and as Windows 10 has no default driver for it, disable it to not scare end users about "missing" drivers.
Change-Id: I0b42a9b55f00826c5920c1c259b38382bdcdde72 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42509 Reviewed-by: Christian Walter christian.walter@9elements.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/prodrive/hermes/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Christian Walter: Looks good to me, approved
diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb index 45bd422..c55ac92 100644 --- a/src/mainboard/prodrive/hermes/devicetree.cb +++ b/src/mainboard/prodrive/hermes/devicetree.cb @@ -21,7 +21,7 @@ device pci 08.0 on end # Gaussian Mixture device pci 12.0 on end # Thermal Subsystem device pci 14.0 on end # USB xHCI - device pci 14.1 on end # USB xDCI (OTG) + device pci 14.1 off end # USB xDCI (OTG) device pci 14.2 on end # RAM controller device pci 14.5 off end # SDCard
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)