Krishna P Bhat D has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45481 )
Change subject: soc/intel/jasperlake: Add IGD Device ID ......................................................................
soc/intel/jasperlake: Add IGD Device ID
Add IGD Device ID for Jasperlake. Reference is taken from Jasperlake EDS volume 1(Document Number: 613601).
TEST=Build and boot Jasperlake platform.
Change-Id: I00ee7950ffa378b428a76bf367a9a05ab287e7ed Signed-off-by: Krishna Prasad Bhat krishna.p.bhat.d@intel.com --- M src/include/device/pci_ids.h M src/soc/intel/common/block/graphics/graphics.c M src/soc/intel/jasperlake/bootblock/report_platform.c 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45481/1
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 944c20e..11f81dd 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3637,6 +3637,7 @@ #define PCI_DEVICE_ID_INTEL_JSL_GT1 0x4E51 #define PCI_DEVICE_ID_INTEL_JSL_GT2 0x4E71 #define PCI_DEVICE_ID_INTEL_JSL_GT3 0x4E61 +#define PCI_DEVICE_ID_INTEL_JSL_GT4 0x4E55
#define PCI_DEVICE_ID_INTEL_ADL_GT0 0x46ff #define PCI_DEVICE_ID_INTEL_ADL_GT1 0x4600 diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c index 4561a38..23cf847 100644 --- a/src/soc/intel/common/block/graphics/graphics.c +++ b/src/soc/intel/common/block/graphics/graphics.c @@ -283,6 +283,7 @@ PCI_DEVICE_ID_INTEL_JSL_GT1, PCI_DEVICE_ID_INTEL_JSL_GT2, PCI_DEVICE_ID_INTEL_JSL_GT3, + PCI_DEVICE_ID_INTEL_JSL_GT4, PCI_DEVICE_ID_INTEL_ADL_GT0, PCI_DEVICE_ID_INTEL_ADL_GT1, PCI_DEVICE_ID_INTEL_ADL_GT1_1, diff --git a/src/soc/intel/jasperlake/bootblock/report_platform.c b/src/soc/intel/jasperlake/bootblock/report_platform.c index d7eb490..fa5ca69 100644 --- a/src/soc/intel/jasperlake/bootblock/report_platform.c +++ b/src/soc/intel/jasperlake/bootblock/report_platform.c @@ -45,6 +45,7 @@ { PCI_DEVICE_ID_INTEL_JSL_GT1, "Jasperlake GT1" }, { PCI_DEVICE_ID_INTEL_JSL_GT2, "Jasperlake GT2" }, { PCI_DEVICE_ID_INTEL_JSL_GT3, "Jasperlake GT3" }, + { PCI_DEVICE_ID_INTEL_JSL_GT4, "Jasperlake GT4" }, };
static inline uint8_t get_dev_revision(pci_devfn_t dev)
Hello V Sowmya, build bot (Jenkins), Maulik V Vaghela, Subrata Banik, Aamir Bohra, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45481
to look at the new patch set (#2).
Change subject: soc/intel/jasperlake: Add IGD, MCH Device ID ......................................................................
soc/intel/jasperlake: Add IGD, MCH Device ID
Add IGD Device ID and MCH Device ID for Jasperlake. Reference is taken from Jasperlake EDS volume 1(Document Number: 613601).
TEST=Build and boot Jasperlake platform.
Change-Id: I00ee7950ffa378b428a76bf367a9a05ab287e7ed Signed-off-by: Krishna Prasad Bhat krishna.p.bhat.d@intel.com --- M src/include/device/pci_ids.h M src/soc/intel/common/block/graphics/graphics.c M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/jasperlake/bootblock/report_platform.c 4 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45481/2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45481 )
Change subject: soc/intel/jasperlake: Add IGD, MCH Device ID ......................................................................
Patch Set 2: Code-Review+2
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45481 )
Change subject: soc/intel/jasperlake: Add IGD, MCH Device ID ......................................................................
Patch Set 2: Code-Review+2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45481 )
Change subject: soc/intel/jasperlake: Add IGD, MCH Device ID ......................................................................
Patch Set 2: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45481 )
Change subject: soc/intel/jasperlake: Add IGD, MCH Device ID ......................................................................
soc/intel/jasperlake: Add IGD, MCH Device ID
Add IGD Device ID and MCH Device ID for Jasperlake. Reference is taken from Jasperlake EDS volume 1(Document Number: 613601).
TEST=Build and boot Jasperlake platform.
Change-Id: I00ee7950ffa378b428a76bf367a9a05ab287e7ed Signed-off-by: Krishna Prasad Bhat krishna.p.bhat.d@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45481 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aamir Bohra aamir.bohra@intel.com Reviewed-by: V Sowmya v.sowmya@intel.com Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/include/device/pci_ids.h M src/soc/intel/common/block/graphics/graphics.c M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/jasperlake/bootblock/report_platform.c 4 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Aamir Bohra: Looks good to me, approved V Sowmya: Looks good to me, approved
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index e9674df..d40d867 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3638,6 +3638,7 @@ #define PCI_DEVICE_ID_INTEL_JSL_GT1 0x4E51 #define PCI_DEVICE_ID_INTEL_JSL_GT2 0x4E71 #define PCI_DEVICE_ID_INTEL_JSL_GT3 0x4E61 +#define PCI_DEVICE_ID_INTEL_JSL_GT4 0x4E55
#define PCI_DEVICE_ID_INTEL_ADL_GT0 0x46ff #define PCI_DEVICE_ID_INTEL_ADL_GT1 0x4600 @@ -3729,6 +3730,7 @@ #define PCI_DEVICE_ID_INTEL_JSL_ID_2 0x4e26 #define PCI_DEVICE_ID_INTEL_JSL_ID_3 0x4e12 #define PCI_DEVICE_ID_INTEL_JSL_ID_4 0x4e14 +#define PCI_DEVICE_ID_INTEL_JSL_ID_5 0x4e24
#define PCI_DEVICE_ID_INTEL_ADL_S_ID_1 0x4660 #define PCI_DEVICE_ID_INTEL_ADL_S_ID_2 0x4664 diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c index 4561a38..23cf847 100644 --- a/src/soc/intel/common/block/graphics/graphics.c +++ b/src/soc/intel/common/block/graphics/graphics.c @@ -283,6 +283,7 @@ PCI_DEVICE_ID_INTEL_JSL_GT1, PCI_DEVICE_ID_INTEL_JSL_GT2, PCI_DEVICE_ID_INTEL_JSL_GT3, + PCI_DEVICE_ID_INTEL_JSL_GT4, PCI_DEVICE_ID_INTEL_ADL_GT0, PCI_DEVICE_ID_INTEL_ADL_GT1, PCI_DEVICE_ID_INTEL_ADL_GT1_1, diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c index bbccc89..4c5731f 100644 --- a/src/soc/intel/common/block/systemagent/systemagent.c +++ b/src/soc/intel/common/block/systemagent/systemagent.c @@ -386,6 +386,7 @@ PCI_DEVICE_ID_INTEL_JSL_ID_2, PCI_DEVICE_ID_INTEL_JSL_ID_3, PCI_DEVICE_ID_INTEL_JSL_ID_4, + PCI_DEVICE_ID_INTEL_JSL_ID_5, PCI_DEVICE_ID_INTEL_ADL_S_ID_1, PCI_DEVICE_ID_INTEL_ADL_S_ID_2, PCI_DEVICE_ID_INTEL_ADL_S_ID_3, diff --git a/src/soc/intel/jasperlake/bootblock/report_platform.c b/src/soc/intel/jasperlake/bootblock/report_platform.c index d7eb490..beab782 100644 --- a/src/soc/intel/jasperlake/bootblock/report_platform.c +++ b/src/soc/intel/jasperlake/bootblock/report_platform.c @@ -29,6 +29,7 @@ { PCI_DEVICE_ID_INTEL_JSL_ID_2, "Jasperlake SKU4-2" }, { PCI_DEVICE_ID_INTEL_JSL_ID_3, "Jasperlake SKU2-1" }, { PCI_DEVICE_ID_INTEL_JSL_ID_4, "Jasperlake SKU2-2" }, + { PCI_DEVICE_ID_INTEL_JSL_ID_5, "Jasperlake SKU4-3" }, };
static struct { @@ -45,6 +46,7 @@ { PCI_DEVICE_ID_INTEL_JSL_GT1, "Jasperlake GT1" }, { PCI_DEVICE_ID_INTEL_JSL_GT2, "Jasperlake GT2" }, { PCI_DEVICE_ID_INTEL_JSL_GT3, "Jasperlake GT3" }, + { PCI_DEVICE_ID_INTEL_JSL_GT4, "Jasperlake GT4" }, };
static inline uint8_t get_dev_revision(pci_devfn_t dev)
-
Aamir Bohra (Code Review) -
Krishna P Bhat D (Code Review)
-
Subrata Banik (Code Review)
-
V Sowmya (Code Review)