Change in ...coreboot[master]: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5
Roy Mingi Park has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32360
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
soc/intel/common/acpi: Fix leakage power on Touchscreen during S5
Leakage power is observed from 3V_TSP_S0_FUSE during S5. To avoid leakage power, GPP_E7 needs to be turned off before S5 entry
BUG=b:129899315 TEST= Measure leakage power in S5 from both Arcada and Sarien
Change-Id: Id63c992df929c1c4a3992905c9189cdacd8c6e42 Signed-off-by: Roy Mingi Park roy.mingi.park@intel.com --- M src/soc/intel/common/acpi/platform.asl 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/32360/1
diff --git a/src/soc/intel/common/acpi/platform.asl b/src/soc/intel/common/acpi/platform.asl index bdc0d5c..3d725b6 100644 --- a/src/soc/intel/common/acpi/platform.asl +++ b/src/soc/intel/common/acpi/platform.asl @@ -34,6 +34,11 @@ { Store (POST_OS_ENTER_PTS, DBG0)
+ if( Arg0 == 5) + { + _SB.PCI0.CTXS(GPP_E7) + } + #if CONFIG(SOC_INTEL_COMMON_ACPI_EC_PTS_WAK) /* Call EC _PTS handler */ _SB.PCI0.LPCB.EC0.PTS (Arg0)
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32360
to look at the new patch set (#2).
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
soc/intel/common/acpi: Fix leakage power on Touchscreen during S5
Leakage power is observed from 3V_TSP_S0_FUSE during S5. To avoid leakage power, GPP_E7 needs to be turned off before S5 entry.
BUG=b:129899315 TEST=Measure leakage power in S5 from both Arcada and Sarien
Change-Id: Id63c992df929c1c4a3992905c9189cdacd8c6e42 Signed-off-by: Roy Mingi Park roy.mingi.park@intel.com --- M src/soc/intel/common/acpi/platform.asl 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/32360/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32360 )
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
Patch Set 2:
please ask Lance to move this into board level
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32360 )
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
Patch Set 2: Code-Review-1
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32360 )
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
Patch Set 2:
This could go in the SMI sleep handler for the mainboard.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32360 )
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
Patch Set 2:
This could go in the SMI sleep handler for the mainboard.
_PTS shall be also fine right? Though it will miss the stage that system get shutdown in pre-os stage, and power button smi will shutdown the system
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32360 )
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
Patch Set 2:
Patch Set 2:
This could go in the SMI sleep handler for the mainboard.
_PTS shall be also fine right? Though it will miss the stage that system get shutdown in pre-os stage, and power button smi will shutdown the system
It is just harder to get a mainboard specific change into _PTS.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32360 )
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
Patch Set 2:
Patch Set 2:
This could go in the SMI sleep handler for the mainboard.
_PTS shall be also fine right? Though it will miss the stage that
system get shutdown in pre-os stage, and power button smi will shutdown the system
It is just harder to get a mainboard specific change into _PTS.
https://review.coreboot.org/#/c/coreboot/+/32366/
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32360 )
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
Patch Set 2:
Patch Set 2:
This could go in the SMI sleep handler for the mainboard.
_PTS shall be also fine right? Though it will miss the stage
that
system get shutdown in pre-os stage, and power button smi will shutdown the system
It is just harder to get a mainboard specific change into _PTS.
Use CondRefOf will be a good solution to load the method dynamically?
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32360 )
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
Patch Set 2: -Code-Review
Patch Set 2:
Patch Set 2:
This could go in the SMI sleep handler for the mainboard.
_PTS shall be also fine right? Though it will miss the stage
that
system get shutdown in pre-os stage, and power button smi will shutdown the system
It is just harder to get a mainboard specific change into _PTS.
Use CondRefOf will be a good solution to load the method dynamically?
That hook would be good enough.
Roy Mingi Park has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32360 )
Change subject: soc/intel/common/acpi: Fix leakage power on Touchscreen during S5 ......................................................................
Abandoned
There is board level cl. https://review.coreboot.org/c/coreboot/+/32367
-
Duncan Laurie (Code Review) -
EricR Lai (Code Review)
-
Lijian Zhao (Code Review)
-
Roy Mingi Park (Code Review)