[S] Change in coreboot[main]: mb/google/brox: Check to powergate the UFS controller

[Subrata Banik (Code Review)]

Attention is currently required from: Karthik Ramasubramanian, Sowmya Aralguppe.

Subrata Banik has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/86151?usp=email )

Change subject: mb/google/brox: Check to powergate the UFS controller
......................................................................

Patch Set 3:

(2 comments)

File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/86151/comment/f03d9a0b_d1ecd2f0?usp... :
PS3, Line 113: extern bool mainboard_expects_another_reset(void);
why we need this function to be declared as extern ? are we not adding the header file where we have declared mainboard_expects_another_reset ?

https://review.coreboot.org/c/coreboot/+/86151/comment/3666ddec_ef4affec?usp... :
PS3, Line 114: 
             : static uint8_t pmc_get_pch_ip_pg_sts(uint32_t offset)
             : {
             : 	uint8_t val = 0;
             : 	uintptr_t pmc_bar;
             : 
             : 	pmc_bar = soc_read_pmc_base();
             : 	val = read8p(pmc_bar + offset);
             : 	return val;
             : }
can you please move this into pmclib.c ? looks very generic API and we might need this later