Attention is currently required from: AlanKY Lee, David Lin, Tarun Tuli.
Mac Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76925?usp=email )
Change subject: mb/google/brya/var/skolas: add nau8318 speaker support
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
Hi Mac, ongoing now, we may need to change the GPIO init sequence. […]
Hi Alan,
yup, as you mentioned, the fw_config will be the final sequence which override the GPP_R7 from GPIO to NC again…
I suggest that consider other NC as GPIO pin for SPK_BEEP_EN (not I2S, dmic relative pins) That would solve the sequence overwritten situation.
Otherwise, need to duplicated the entire max98360_enable_pads[] flow to new nau8318_enable_pads[] and handle fw_config separately.
nau8318_enable_pads[] = {
...
PAD_NC(GPP_R7, DEEP),
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76925?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife47a83fca902cf63e09d11206e9d99fac0dc9a1
Gerrit-Change-Number: 76925
Gerrit-PatchSet: 10
Gerrit-Owner: Mac Chiang
mac.chiang@intel.com
Gerrit-Reviewer: AlanKY Lee
alanky_lee@compal.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: David Lin
CTLIN0@nuvoton.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: David Lin
CTLIN0@nuvoton.com
Gerrit-Attention: AlanKY Lee
alanky_lee@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Aug 2023 03:30:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mac Chiang
mac.chiang@intel.com
Comment-In-Reply-To: AlanKY Lee
alanky_lee@compal.corp-partner.google.com
Gerrit-MessageType: comment