Change in coreboot[master]: mb/google/zork/var/vilboz: Update touch screen power sequence

[EricR Lai (Code Review)]

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46929 )

Change subject: mb/google/zork/var/vilboz: Update touch screen power sequence
......................................................................

mb/google/zork/var/vilboz: Update touch screen power sequence

Add ELAN touch support and update Goodix settings.

BUG=b:157265632
BRANCH=zork
TEST=emerge coreboot and check both touch screen are workable.

Signed-off-by: Eric Lai 
Change-Id: Icfc2421061e8b3163d7d5108673351bc17df20ec
---
M src/mainboard/google/zork/variants/vilboz/overridetree.cb
1 file changed, 20 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/46929/1

diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb
index a61c027..6156a57 100644
--- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb
+++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb
@@ -103,16 +103,32 @@
    		register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)"
    		register "generic.probed" = "1"
    		register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_32)"
-			register "generic.enable_delay_ms" = "10"
+			register "generic.enable_delay_ms" = "5"
    		register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)"
-			register "generic.reset_off_delay_ms" = "1"
-			register "generic.reset_delay_ms" = "120"
+			register "generic.reset_off_delay_ms" = "2"
+			register "generic.reset_delay_ms" = "20"
    		register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)"
-			register "generic.stop_off_delay_ms" = "1"
+			register "generic.stop_off_delay_ms" = "2"
    		register "generic.has_power_resource" = "1"
    		register "hid_desc_reg_offset" = "0x01"
    		device i2c 5d on end
    	end
+		chip drivers/i2c/generic
+			register "hid" = ""ELAN0001""
+			register "desc" = ""ELAN Touchscreen""
+			register "probed" = "1"
+			register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)"
+			register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_32)"
+			register "enable_delay_ms" = "1"
+			register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)"
+			register "reset_delay_ms" = "20"
+			register "reset_off_delay_ms" = "2"
+			register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)"
+			register "stop_off_delay_ms" = "2"
+			register "has_power_resource" = "1"
+			register "disable_gpio_export_in_crs" = "1"
+			device i2c 10 on end
+		end
    	chip drivers/generic/gpio_keys
    		register "name" = ""PENH""
    		register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPIO_4)"

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46929 )

Change subject: mb/google/zork/var/vilboz: Update touch screen power sequence
......................................................................

Patch Set 1:

Please refer below spec in the issue.

For Goodix, the touch timing setting is on page 28 in the file "TFT-LCD Preliminary Specification N140HCN-EA1 ver 1.0 for Lenovo C7_200727".
For ELAN, the touch timing setting is on page 26 in the file "B140HAK03 2_HW_3A_Pre_Functional_Spec_V0_1_Lenovo_Z83_0727Y20"

[EricR Lai (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Eric Peers, Rob Barnes, Ivy Jian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46929

to look at the new patch set (#2).

Change subject: mb/google/zork/var/vilboz: Update touch screen power sequence
......................................................................

mb/google/zork/var/vilboz: Update touch screen power sequence

Add ELAN touch support and update Goodix settings.

BUG=b:157265632
BRANCH=zork
TEST=emerge coreboot and check both touch screen are workable.

Signed-off-by: Eric Lai 
Change-Id: Icfc2421061e8b3163d7d5108673351bc17df20ec
---
M src/mainboard/google/zork/variants/vilboz/overridetree.cb
1 file changed, 20 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/46929/2

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46929 )

Change subject: mb/google/zork/var/vilboz: Update touch screen power sequence
......................................................................

Patch Set 2:

@Furquan, goodix program guide seems like contradict to the IC timing on off timing. So set it to IC minimum 2. And add stop_delay 100ms (120-20) for IC ready.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46929 )

Change subject: mb/google/zork/var/vilboz: Update touch screen power sequence
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/46929/2/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46929/2/src/mainboard/google/zork/v... 
PS2, Line 111: "
Is this really 100ms? From the attached datasheet, it didn't look like 100ms delay was required after the stop gpio is deasserted.

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46929 )

Change subject: mb/google/zork/var/vilboz: Update touch screen power sequence
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46929/2/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46929/2/src/mainboard/google/zork/v... 
PS2, Line 111: "
> Is this really 100ms? From the attached datasheet, it didn't look like 100ms delay was required afte […]

Goodix FW need 120ms for IC responds after reset assert. Since we have stop pin, it's better separate with reset_delay 20ms and stop delay 100ms.

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46929 )

Change subject: mb/google/zork/var/vilboz: Update touch screen power sequence
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46929/2/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46929/2/src/mainboard/google/zork/v... 
PS2, Line 111: "
> Goodix FW need 120ms for IC responds after reset assert. […]

https://partnerissuetracker.corp.google.com/issues/138795891#comment6 here is SW guide, please refer P15.

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46929 )

Change subject: mb/google/zork/var/vilboz: Update touch screen power sequence
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46929 )

Change subject: mb/google/zork/var/vilboz: Update touch screen power sequence
......................................................................

mb/google/zork/var/vilboz: Update touch screen power sequence

Add ELAN touch support and update Goodix settings.

BUG=b:157265632
BRANCH=zork
TEST=emerge coreboot and check both touch screen are workable.

Signed-off-by: Eric Lai 
Change-Id: Icfc2421061e8b3163d7d5108673351bc17df20ec
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46929
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Martin Roth 
---
M src/mainboard/google/zork/variants/vilboz/overridetree.cb
1 file changed, 20 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb
index a61c027..bca556c 100644
--- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb
+++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb
@@ -105,14 +105,31 @@
    		register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_32)"
    		register "generic.enable_delay_ms" = "10"
    		register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)"
-			register "generic.reset_off_delay_ms" = "1"
-			register "generic.reset_delay_ms" = "120"
+			register "generic.reset_off_delay_ms" = "2"
+			register "generic.reset_delay_ms" = "20"
    		register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)"
-			register "generic.stop_off_delay_ms" = "1"
+			register "generic.stop_delay_ms" = "100"
+			register "generic.stop_off_delay_ms" = "2"
    		register "generic.has_power_resource" = "1"
    		register "hid_desc_reg_offset" = "0x01"
    		device i2c 5d on end
    	end
+		chip drivers/i2c/generic
+			register "hid" = ""ELAN0001""
+			register "desc" = ""ELAN Touchscreen""
+			register "probed" = "1"
+			register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)"
+			register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_32)"
+			register "enable_delay_ms" = "1"
+			register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)"
+			register "reset_delay_ms" = "20"
+			register "reset_off_delay_ms" = "2"
+			register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)"
+			register "stop_off_delay_ms" = "2"
+			register "has_power_resource" = "1"
+			register "disable_gpio_export_in_crs" = "1"
+			device i2c 10 on end
+		end
    	chip drivers/generic/gpio_keys
    		register "name" = ""PENH""
    		register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPIO_4)"