Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31221
to review the following change.
Change subject: src/mainboard/lenovo/g505s/Kconfig: select NO_INTEL_WIFI option ......................................................................
src/mainboard/lenovo/g505s/Kconfig: select NO_INTEL_WIFI option
There were no G505S shipped with pre-installed Intel PCI-e WiFi adapters, almost all such adapters (except Intel 135) could not be installed under proprietary UEFI because of a whitelist, and I am not aware of anyone who installed them after upgrading to coreboot - maybe because Atheros ath9k have a much better software freedom status and are the preferred choice.
Select NO_INTEL_WIFI option to disable DRIVERS_INTEL_WIFI by default.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I2e32436a88777fa58661611cb9dbca7f56a65b6e --- M src/mainboard/lenovo/g505s/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31221/1
diff --git a/src/mainboard/lenovo/g505s/Kconfig b/src/mainboard/lenovo/g505s/Kconfig index 883ef27..53858ca 100644 --- a/src/mainboard/lenovo/g505s/Kconfig +++ b/src/mainboard/lenovo/g505s/Kconfig @@ -30,6 +30,7 @@ select BOARD_ROMSIZE_KB_4096 select GFXUMA select NO_UART_ON_SUPERIO + select NO_INTEL_WIFI
config MAINBOARD_DIR string
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31221 )
Change subject: src/mainboard/lenovo/g505s/Kconfig: select NO_INTEL_WIFI option ......................................................................
Patch Set 1:
This change depends on CB:31219 which introduced this NO_INTEL_WIFI option. Also you may want to take a look at related CB:31220 change
mikeb mikeb has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31221 )
Change subject: src/mainboard/lenovo/g505s/Kconfig: select NO_INTEL_WIFI option ......................................................................
Abandoned
Moved to CB:31225 for convenience (because another approach has been selected)