Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40594 )
Change subject: mb/google/octopus: Add ACPI backlight controls ......................................................................
mb/google/octopus: Add ACPI backlight controls
Change-Id: I779f7f3f5a111018fc7b5c50c5750a9eb815d670 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/40594/1
diff --git a/src/mainboard/google/octopus/dsdt.asl b/src/mainboard/google/octopus/dsdt.asl index 11313f9..4dbf1c5 100644 --- a/src/mainboard/google/octopus/dsdt.asl +++ b/src/mainboard/google/octopus/dsdt.asl @@ -26,6 +26,7 @@ #include <soc/intel/apollolake/acpi/northbridge.asl> #include <soc/intel/apollolake/acpi/southbridge.asl> #include <soc/intel/apollolake/acpi/pch_hda.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> } }
diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb index 9253f11..69ea309 100644 --- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb @@ -3,6 +3,9 @@ device lapic 0 on end end
+ # IGD Displays + register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "pcie_rp_clkreq_pin[2]" = "3" # wifi/bt # Disable unused clkreq of PCIe root ports register "pcie_rp_clkreq_pin[0]" = "CLKREQ_DISABLED"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40594 )
Change subject: mb/google/octopus: Add ACPI backlight controls ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40594
to look at the new patch set (#2).
Change subject: mb/google/octopus: Add ACPI backlight controls ......................................................................
mb/google/octopus: Add ACPI backlight controls
Change-Id: I779f7f3f5a111018fc7b5c50c5750a9eb815d670 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/40594/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40594 )
Change subject: mb/google/octopus: Add ACPI backlight controls ......................................................................
Patch Set 3: Code-Review+1
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40594 )
Change subject: mb/google/octopus: Add ACPI backlight controls ......................................................................
Patch Set 4:
I'll rebase this on top of CB:49054 once that's sorted
Hello build bot (Jenkins), Angel Pons, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40594
to look at the new patch set (#5).
Change subject: mb/google/octopus: Add ACPI backlight controls ......................................................................
mb/google/octopus: Add ACPI backlight controls
Enables backlight control under Windows 10.
Test: build/boot Windows 10 20H2 on google/ampton, verify display backlight controls functional.
Change-Id: I779f7f3f5a111018fc7b5c50c5750a9eb815d670 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/40594/5
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40594 )
Change subject: mb/google/octopus: Add ACPI backlight controls ......................................................................
Patch Set 5: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40594 )
Change subject: mb/google/octopus: Add ACPI backlight controls ......................................................................
Patch Set 5: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40594 )
Change subject: mb/google/octopus: Add ACPI backlight controls ......................................................................
mb/google/octopus: Add ACPI backlight controls
Enables backlight control under Windows 10.
Test: build/boot Windows 10 20H2 on google/ampton, verify display backlight controls functional.
Change-Id: I779f7f3f5a111018fc7b5c50c5750a9eb815d670 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40594 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 2 files changed, 4 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/dsdt.asl b/src/mainboard/google/octopus/dsdt.asl index f87b962..513db66 100644 --- a/src/mainboard/google/octopus/dsdt.asl +++ b/src/mainboard/google/octopus/dsdt.asl @@ -25,6 +25,7 @@ #include <soc/intel/apollolake/acpi/northbridge.asl> #include <soc/intel/apollolake/acpi/southbridge.asl> #include <soc/intel/apollolake/acpi/pch_hda.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> } }
diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb index cbcd48a..3dbc5ef 100644 --- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb @@ -112,7 +112,9 @@ device pci 00.0 on end # - Host Bridge device pci 00.1 on end # - DPTF device pci 00.2 off end # - NPK - device pci 02.0 on end # - Gen + device pci 02.0 on # - Gen + register "gfx" = "GMA_DEFAULT_PANEL(0)" + end device pci 03.0 on end # - Gaussian Mixture Model (GMM) device pci 0c.0 on chip drivers/wifi/generic
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Michael Niewöhner (Code Review)