Attention is currently required from: Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56035 )
Change subject: mb/siemens/mc_ehl: Switch to 16 MB ROM and provide a flashmap
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/siemens/mc_ehl/mc_ehl.fmd:
https://review.coreboot.org/c/coreboot/+/56035/comment/5692c5cf_68b149a5
PS2, Line 9: 0xbefe00
Cool, this is new to me. Nice feature, will change.
Done
File src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig:
https://review.coreboot.org/c/coreboot/+/56035/comment/0c315df3_37176cb1
PS2, Line 3: config BOARD_SPECIFIC_OPTIONS
: def_bool y
Will be used in the next commits. But yes, I can remove for this commit and add in later.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I694729ad98f91e27308220903c49e7cb7fc436b4
Gerrit-Change-Number: 56035
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 05 Jul 2021 12:34:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment