Attention is currently required from: Kyösti Mälkki.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55930 )
Change subject: nb/amd/agesa: Clean up some math expressions
......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/55930/comment/c6e798c7_92d2890a
PS2, Line 558: if ((basek < 640) && (sizek > 768))
maybe: "if ((basek < (0xa0000 >> 10) && sizek > (0xc0000 >> 10)))" ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6a1a6123dc0e2afd04213ece13363eed29f92c0
Gerrit-Change-Number: 55930
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 17 Feb 2022 06:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment