Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36479 )
Change subject: vendorcode/eltan: cleanup of Kconfig files ......................................................................
vendorcode/eltan: cleanup of Kconfig files
The vendorcode/eltan and vendorcode/eltan/security directories were both adding the mboot and verified_boot Kconfigs.
BUG=N/A TEST=build
Change-Id: I6b5f19b4660d60345391b7320ce42466fd2cc769 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/vendorcode/eltan/Kconfig M src/vendorcode/eltan/security/Kconfig 2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/36479/1
diff --git a/src/vendorcode/eltan/Kconfig b/src/vendorcode/eltan/Kconfig index dc756ab..319e90a 100644 --- a/src/vendorcode/eltan/Kconfig +++ b/src/vendorcode/eltan/Kconfig @@ -1,7 +1,7 @@ ## ## This file is part of the coreboot project. ## -## Copyright (C) 2014-2018 Eltan B.V. +## Copyright (C) 2014-2019 Eltan B.V. ## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by @@ -17,6 +17,5 @@ bool
if USE_VENDORCODE_ELTAN -source src/vendorcode/eltan/security/mboot/Kconfig -source src/vendorcode/eltan/security/verified_boot/Kconfig +source src/vendorcode/eltan/security/Kconfig endif diff --git a/src/vendorcode/eltan/security/Kconfig b/src/vendorcode/eltan/security/Kconfig index 2af5808..6b93d2a 100644 --- a/src/vendorcode/eltan/security/Kconfig +++ b/src/vendorcode/eltan/security/Kconfig @@ -1,6 +1,6 @@ ## This file is part of the coreboot project. ## -## Copyright (C) 2018 Eltan B.V. +## Copyright (C) 2018-2019 Eltan B.V. ## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by @@ -12,5 +12,7 @@ ## GNU General Public License for more details. ##
+menu "Eltan Security Settings" source src/vendorcode/eltan/security/mboot/Kconfig source src/vendorcode/eltan/security/verified_boot/Kconfig +endmenu
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36479 )
Change subject: vendorcode/eltan: cleanup of Kconfig files ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
+2 if copyright notices weren't that confusing.
https://review.coreboot.org/c/coreboot/+/36479/1/src/vendorcode/eltan/Kconfi... File src/vendorcode/eltan/Kconfig:
https://review.coreboot.org/c/coreboot/+/36479/1/src/vendorcode/eltan/Kconfi... PS1, Line 4: 2014-2019 Giving a range here is usually interpreted as each year individually. It translates to: 2014, 2015, 2016, 2017, 2018 and 2019.
One is supposed to add such a copyright notice for each year when a significant, creative part was added (minor changes don't count). IMHO, if we were honest, there wouldn't be any copyright notice here. But there are six. For five lines.
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36479 )
Change subject: vendorcode/eltan: cleanup of Kconfig files ......................................................................
Patch Set 1:
(1 comment)
changed the copyright notice and add the reasoning behind the range definition.
https://review.coreboot.org/c/coreboot/+/36479/1/src/vendorcode/eltan/Kconfi... File src/vendorcode/eltan/Kconfig:
https://review.coreboot.org/c/coreboot/+/36479/1/src/vendorcode/eltan/Kconfi... PS1, Line 4: 2014-2019
Giving a range here is usually interpreted as each year individually. It […]
As far as I your interpretation of a range is not correct. In my opinion, this means that the file was created in 2014 and last updated in 2019. It doesn't state anything about the frequency of the changes.
I looked it up and found the explanation below on: https://epiphany.law/articles/copyright/copyright-dates-single-year-or-range
Once in a while, you might see what looks like a date range instead of a single year of first publication, such as: Epiphany Law Pty Ltd, 2006-2016. This is appropriate for ‘documents’ such as web pages or software programs which are constantly being revised and updated incrementally. The ‘start’ year should be the date of the oldest content still contained in the work, with the ‘end’ year being the last year that the work was revised.
This is basically independent of the comment that the copyright to code ratio is a bit odd. I will change it to 2019 as this is the first version on coreboot anyhow
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36479
to look at the new patch set (#2).
Change subject: vendorcode/eltan: cleanup of Kconfig files ......................................................................
vendorcode/eltan: cleanup of Kconfig files
The vendorcode/eltan and vendorcode/eltan/security directories were both adding the mboot and verified_boot Kconfigs.
BUG=N/A TEST=build
Change-Id: I6b5f19b4660d60345391b7320ce42466fd2cc769 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/vendorcode/eltan/Kconfig M src/vendorcode/eltan/security/Kconfig 2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/36479/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36479 )
Change subject: vendorcode/eltan: cleanup of Kconfig files ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36479 )
Change subject: vendorcode/eltan: cleanup of Kconfig files ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36479/1/src/vendorcode/eltan/Kconfi... File src/vendorcode/eltan/Kconfig:
https://review.coreboot.org/c/coreboot/+/36479/1/src/vendorcode/eltan/Kconfi... PS1, Line 4: 2014-2019
As far as I your interpretation of a range is not correct. In my opinion, this means that the file was created in 2014 and last updated in 2019.
That disagrees with the article you linked below.
It doesn't state anything about the frequency of the changes.
I looked it up and found the explanation below on: https://epiphany.law/articles/copyright/copyright-dates-single-year-or-range
Once in a while, you might see what looks like a date range instead of a single year of first publication, such as: Epiphany Law Pty Ltd, 2006-2016. This is appropriate for ‘documents’ such as web pages or software programs which are constantly being revised and updated incrementally. The ‘start’ year should be the date of the oldest content still contained in the work, with the ‘end’ year being the last year that the work was revised.
This is oversimplifying things. But so was I. It's not worth arguing about, as copyright doesn't apply to this kind of file, IMHO.
This is basically independent of the comment that the copyright to code ratio is a bit odd. I will change it to 2019 as this is the first version on coreboot anyhow
What matters most is the year of the first publication, if that is 2019, sounds good to me.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36479 )
Change subject: vendorcode/eltan: cleanup of Kconfig files ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36479/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36479/2//COMMIT_MSG@7 PS2, Line 7: vendorcode/eltan: cleanup of Kconfig files Please make it a statement:
Clean up Kconfig files
Hello Frans Hendriks, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36479
to look at the new patch set (#3).
Change subject: vendorcode/eltan: Cleanup of Kconfig files ......................................................................
vendorcode/eltan: Cleanup of Kconfig files
The vendorcode/eltan and vendorcode/eltan/security directories were both adding the mboot and verified_boot Kconfigs.
BUG=N/A TEST=build
Change-Id: I6b5f19b4660d60345391b7320ce42466fd2cc769 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/vendorcode/eltan/Kconfig M src/vendorcode/eltan/security/Kconfig 2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/36479/3
Hello Frans Hendriks, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36479
to look at the new patch set (#4).
Change subject: vendorcode/eltan: Cleanup Kconfig files ......................................................................
vendorcode/eltan: Cleanup Kconfig files
The vendorcode/eltan and vendorcode/eltan/security directories were both adding the mboot and verified_boot Kconfigs.
BUG=N/A TEST=build
Change-Id: I6b5f19b4660d60345391b7320ce42466fd2cc769 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/vendorcode/eltan/Kconfig M src/vendorcode/eltan/security/Kconfig 2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/36479/4
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36479 )
Change subject: vendorcode/eltan: Cleanup Kconfig files ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36479/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36479/2//COMMIT_MSG@7 PS2, Line 7: vendorcode/eltan: cleanup of Kconfig files
Please make it a statement: […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36479 )
Change subject: vendorcode/eltan: Cleanup Kconfig files ......................................................................
vendorcode/eltan: Cleanup Kconfig files
The vendorcode/eltan and vendorcode/eltan/security directories were both adding the mboot and verified_boot Kconfigs.
BUG=N/A TEST=build
Change-Id: I6b5f19b4660d60345391b7320ce42466fd2cc769 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36479 Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/eltan/Kconfig M src/vendorcode/eltan/security/Kconfig 2 files changed, 5 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/vendorcode/eltan/Kconfig b/src/vendorcode/eltan/Kconfig index dc756ab..30bb8b8 100644 --- a/src/vendorcode/eltan/Kconfig +++ b/src/vendorcode/eltan/Kconfig @@ -1,7 +1,7 @@ ## ## This file is part of the coreboot project. ## -## Copyright (C) 2014-2018 Eltan B.V. +## Copyright (C) 2019 Eltan B.V. ## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by @@ -17,6 +17,5 @@ bool
if USE_VENDORCODE_ELTAN -source src/vendorcode/eltan/security/mboot/Kconfig -source src/vendorcode/eltan/security/verified_boot/Kconfig +source src/vendorcode/eltan/security/Kconfig endif diff --git a/src/vendorcode/eltan/security/Kconfig b/src/vendorcode/eltan/security/Kconfig index 2af5808..6b93d2a 100644 --- a/src/vendorcode/eltan/security/Kconfig +++ b/src/vendorcode/eltan/security/Kconfig @@ -1,6 +1,6 @@ ## This file is part of the coreboot project. ## -## Copyright (C) 2018 Eltan B.V. +## Copyright (C) 2018-2019 Eltan B.V. ## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by @@ -12,5 +12,7 @@ ## GNU General Public License for more details. ##
+menu "Eltan Security Settings" source src/vendorcode/eltan/security/mboot/Kconfig source src/vendorcode/eltan/security/verified_boot/Kconfig +endmenu
-
Frans Hendriks (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)