Hannah Williams (hannah.williams@intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15054
-gerrit
commit de3ff363eca8515901b840bb78deca5462a6e52b Author: Hannah Williams hannah.williams@intel.com Date: Fri Apr 29 14:48:20 2016 -0700
soc/apollolake: Put CSE to low power state
fsp_notify(END_OF_FIRMWARE) should be sent to FSP to enable putting CSE in low power state
Change-Id: I76b8e85ccf077032616ba8e4a333d9264dc65ed2 Signed-off-by: Hannah Williams hannah.williams@intel.com --- src/soc/intel/apollolake/chip.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index d7c61c1..d8ea38e 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -138,6 +138,9 @@ static void fsp_notify_dummy(void *arg)
if (fsp_notify(ph) != FSP_SUCCESS) printk(BIOS_CRIT, "FspNotify failed!\n"); + /* Call END_OF_FIRMWARE Notify after READY_TO_BOOT Notify */ + if (ph == READY_TO_BOOT) + fsp_notify_dummy(END_OF_FIRMWARE); }
BOOT_STATE_INIT_ENTRY(BS_DEV_RESOURCES, BS_ON_EXIT, fsp_notify_dummy,