build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28719 )
Change subject: sb/amd/pi/hudson: Add SPI controller support ......................................................................
Patch Set 1:
(22 comments)
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c File src/southbridge/amd/pi/hudson/spi.c:
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 75: while ((spi_read(SPI_REG_CNTRL02) & CNTRL02_EXEC_OPCODE) && trailing statements should be on next line
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 117: for (count = 0; count < bytesout; count++, dout++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 126: for (count = 0; count < bytesout; count++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 130: for (count = 0; count < bytesin; count++, din++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 139: if (!IS_ENABLED (CONFIG_HUDSON_IMC_FWM)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 148: if (!IS_ENABLED (CONFIG_HUDSON_IMC_FWM)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 162: .xfer_vector = xfer_vectors, code indent should use tabs where possible
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 162: .xfer_vector = xfer_vectors, please, no spaces at the start of a line
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 163: .max_xfer_size = AMD_SB_SPI_TX_LEN, code indent should use tabs where possible
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 163: .max_xfer_size = AMD_SB_SPI_TX_LEN, please, no spaces at the start of a line
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 164: .flags = SPI_CNTRLR_DEDUCT_CMD_LEN, code indent should use tabs where possible
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 164: .flags = SPI_CNTRLR_DEDUCT_CMD_LEN, please, no spaces at the start of a line
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 168: { code indent should use tabs where possible
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 168: { please, no spaces at the start of a line
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 169: .ctrlr = &spi_ctrlr, code indent should use tabs where possible
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 169: .ctrlr = &spi_ctrlr, please, no spaces at the start of a line
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 170: .bus_start = 0, code indent should use tabs where possible
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 170: .bus_start = 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 171: .bus_end = 0, code indent should use tabs where possible
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 171: .bus_end = 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 172: }, code indent should use tabs where possible
https://review.coreboot.org/#/c/28719/1/src/southbridge/amd/pi/hudson/spi.c@... PS1, Line 172: }, please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)