Change in coreboot[master]: console: serial: add optional delay to wait for BMC serial routing

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36591 )

Change subject: console: serial: add optional delay to wait for BMC serial routing
......................................................................

Patch Set 4:
> Patch Set 4:
> > Patch Set 4:
> > > Patch Set 4:
> > > > Patch Set 4:
> > > >
> > > > I'm not really convinced that adding quirk handling in generic common code like this is such a good idea. What is wrong with the current code which adds a delay in the bootblock in the mainboard code?
> > >
> > > Because not only one board has that problem
> >
> > The mainboard bootblock code is always supposed to setup the superio at the moment so handling the quirks there is the best place to do that. It's ok to have some duplication of that. Exposing the amounts of seconds in Kconfig is not really nice, but that's a personal opinion. I don't like Kconfig options to be something you have to tune and experiment with to get it right. It should present just options that are meaningful for different use cases.
> > I don't like Kconfig options to be something you have to tune and experiment with to get it right.
>
> You don't have to. The default value which works is set by the board; see follow-up commit. When the user flashes a fixed BMC he can simply set it to 0 or any other value that fits then.
>
> Having a hard-coded delay is not what we would want. This CB makes it dynamic by checking how much time is needed to wait. The mb approach *always* delays 1s.

If we don't want to have a Kconfig for the seconds, we could set in in devicetree and make the CONFIG_BUG_.... user selectable