Attention is currently required from: Derek Huang, Dinesh Gehlot, Kapil Porwal, Leo Chou, Nick Vaccaro, Paul Menzel, Shou-Chieh Hsu, Subrata Banik.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81613?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya/var/sundance: Add GPIO table
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brya/variants/sundance/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/81613/comment/6c582c5e_8c19530c :
PS5, Line 1: # SPDX-License-Identifier: GPL-2.0-only
empty line after this line ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81613?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53ed5874347006985ca5231d1531fa519088f796
Gerrit-Change-Number: 81613
Gerrit-PatchSet: 5
Gerrit-Owner: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Apr 2024 11:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment