Change in coreboot[master]: UPSTREAM: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support
Duan huayang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44011 )
Change subject: UPSTREAM: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support ......................................................................
UPSTREAM: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support
Support 8GB MT53E2G32D4NQ-046 discrete DDR bootup.
BUG=b:159301679 BRANCH=none TEST=Boots correctly on Kukui.
Change-Id: Ide01f029c5ebd6c3ae6350f73f3c60b818d51353 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E2G32D4NQ-046-8GB.c 3 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/44011/1
diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c index 7638853..5bf6571 100644 --- a/src/mainboard/google/kukui/sdram_configs.c +++ b/src/mainboard/google/kukui/sdram_configs.c @@ -20,6 +20,7 @@ [6] = "sdram-lpddr4x-KMDV6001DA-B620-4GB", [7] = "sdram-lpddr4x-SDADA4CR-128G-4GB", [8] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB", + [9] = "sdram-lpddr4x-MT53E2G32D4NQ-046-8GB", [10] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", #endif }; diff --git a/src/mainboard/google/kukui/sdram_params/Makefile.inc b/src/mainboard/google/kukui/sdram_params/Makefile.inc index 2b43519..e8dc639 100644 --- a/src/mainboard/google/kukui/sdram_params/Makefile.inc +++ b/src/mainboard/google/kukui/sdram_params/Makefile.inc @@ -14,6 +14,7 @@ sdram-params += sdram-lpddr4x-KMDV6001DA-B620-4GB sdram-params += sdram-lpddr4x-SDADA4CR-128G-4GB sdram-params += sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB + sdram-params += sdram-lpddr4x-MT53E2G32D4NQ-046-8GB endif
$(foreach params,$(sdram-params), \ diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E2G32D4NQ-046-8GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E2G32D4NQ-046-8GB.c new file mode 100644 index 0000000..81887b5 --- /dev/null +++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E2G32D4NQ-046-8GB.c @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <soc/emi.h> + +struct sdram_params params = { + .source = DRAMC_PARAM_SOURCE_SDRAM_CONFIG, + .frequency = 1600, + .wr_level = { + [CHANNEL_A] = { {0x1F, 0x19}, {0x20, 0x1A} }, + [CHANNEL_B] = { {0x22, 0x1E}, {0x22, 0x1E} } + }, + .cbt_cs_dly = { + [CHANNEL_A] = {0x5, 0x4}, + [CHANNEL_B] = {0x8, 0x8} + }, + .cbt_final_vref = { + [CHANNEL_A] = {0x56, 0x56}, + [CHANNEL_B] = {0x56, 0x56} + }, + .emi_cona_val = 0xF053F154, + .emi_conh_val = 0x44440003, + .emi_conf_val = 0x00421000, + .chn_emi_cona_val = {0x0444F051, 0x0444F051}, + .cbt_mode_extern = CBT_NORMAL_MODE, + .delay_cell_unit = 868, +};
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44011 )
Change subject: UPSTREAM: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support ......................................................................
Patch Set 1: Code-Review+2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44011 )
Change subject: UPSTREAM: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44011/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44011/1//COMMIT_MSG@7 PS1, Line 7: UPSTREAM: Remove this?
https://review.coreboot.org/c/coreboot/+/44011/1//COMMIT_MSG@12 PS1, Line 12: none kukui
Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44011 )
Change subject: UPSTREAM: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44011/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44011/1//COMMIT_MSG@7 PS1, Line 7: UPSTREAM:
Remove this?
Done
https://review.coreboot.org/c/coreboot/+/44011/1//COMMIT_MSG@12 PS1, Line 12: none
kukui
Done
Hello Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44011
to look at the new patch set (#2).
Change subject: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support ......................................................................
mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support
Support 8GB MT53E2G32D4NQ-046 discrete DDR bootup.
BUG=b:159301679 BRANCH=kukui TEST=Boots correctly on Kukui.
Change-Id: Ide01f029c5ebd6c3ae6350f73f3c60b818d51353 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E2G32D4NQ-046-8GB.c 3 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/44011/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44011 )
Change subject: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44011/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/44011/2/src/mainboard/google/kukui/... PS2, Line 23: [9] = "sdram-lpddr4x-MT53E2G32D4NQ-046-8GB", code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44011/2/src/mainboard/google/kukui/... PS2, Line 23: [9] = "sdram-lpddr4x-MT53E2G32D4NQ-046-8GB", please, no spaces at the start of a line
Hello Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44011
to look at the new patch set (#3).
Change subject: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support ......................................................................
mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support
Support 8GB MT53E2G32D4NQ-046 discrete DDR bootup.
BUG=b:159301679 BRANCH=kukui TEST=Boots correctly on Kukui.
Change-Id: Ide01f029c5ebd6c3ae6350f73f3c60b818d51353 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E2G32D4NQ-046-8GB.c 3 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/44011/3
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44011 )
Change subject: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44011 )
Change subject: mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support ......................................................................
mb/google/kukui: Add Micron 8GB discrete LPDDR4X DDR support
Support 8GB MT53E2G32D4NQ-046 discrete DDR bootup.
BUG=b:159301679 BRANCH=kukui TEST=Boots correctly on Kukui.
Change-Id: Ide01f029c5ebd6c3ae6350f73f3c60b818d51353 Signed-off-by: Huayang Duan huayang.duan@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44011 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Yu-Ping Wu yupingso@google.com --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E2G32D4NQ-046-8GB.c 3 files changed, 28 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c index 7638853..5bf6571 100644 --- a/src/mainboard/google/kukui/sdram_configs.c +++ b/src/mainboard/google/kukui/sdram_configs.c @@ -20,6 +20,7 @@ [6] = "sdram-lpddr4x-KMDV6001DA-B620-4GB", [7] = "sdram-lpddr4x-SDADA4CR-128G-4GB", [8] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB", + [9] = "sdram-lpddr4x-MT53E2G32D4NQ-046-8GB", [10] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", #endif }; diff --git a/src/mainboard/google/kukui/sdram_params/Makefile.inc b/src/mainboard/google/kukui/sdram_params/Makefile.inc index 2b43519..e8dc639 100644 --- a/src/mainboard/google/kukui/sdram_params/Makefile.inc +++ b/src/mainboard/google/kukui/sdram_params/Makefile.inc @@ -14,6 +14,7 @@ sdram-params += sdram-lpddr4x-KMDV6001DA-B620-4GB sdram-params += sdram-lpddr4x-SDADA4CR-128G-4GB sdram-params += sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB + sdram-params += sdram-lpddr4x-MT53E2G32D4NQ-046-8GB endif
$(foreach params,$(sdram-params), \ diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E2G32D4NQ-046-8GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E2G32D4NQ-046-8GB.c new file mode 100644 index 0000000..81887b5 --- /dev/null +++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E2G32D4NQ-046-8GB.c @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <soc/emi.h> + +struct sdram_params params = { + .source = DRAMC_PARAM_SOURCE_SDRAM_CONFIG, + .frequency = 1600, + .wr_level = { + [CHANNEL_A] = { {0x1F, 0x19}, {0x20, 0x1A} }, + [CHANNEL_B] = { {0x22, 0x1E}, {0x22, 0x1E} } + }, + .cbt_cs_dly = { + [CHANNEL_A] = {0x5, 0x4}, + [CHANNEL_B] = {0x8, 0x8} + }, + .cbt_final_vref = { + [CHANNEL_A] = {0x56, 0x56}, + [CHANNEL_B] = {0x56, 0x56} + }, + .emi_cona_val = 0xF053F154, + .emi_conh_val = 0x44440003, + .emi_conf_val = 0x00421000, + .chn_emi_cona_val = {0x0444F051, 0x0444F051}, + .cbt_mode_extern = CBT_NORMAL_MODE, + .delay_cell_unit = 868, +};
-
build bot (Jenkins) (Code Review) -
Duan huayang (Code Review)
-
Hung-Te Lin (Code Review)
-
Patrick Georgi (Code Review)
-
Yu-Ping Wu (Code Review)