Change in coreboot[master]: mb/google/volteer/variant/eldrid: switch to devtree aliases for PMC M...
Scott Chao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48066 )
Change subject: mb/google/volteer/variant/eldrid: switch to devtree aliases for PMC MUX connectors ......................................................................
mb/google/volteer/variant/eldrid: switch to devtree aliases for PMC MUX connectors
Now that soc_get_pmc_mux_device() is gone, the PMC MUX connector devices can be hooked up together via devicetree aliases.
BUG=b:172528109 BRANCH=firmware-volteer-13521.B TEST=built and USB3.0, type-c display work.
Signed-off-by: Scott Chao scott_chao@wistron.corp-partner.google.com Change-Id: Iedf9b972b341064ff62a4443bfa83f69c8c60108 --- M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/48066/1
diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index 72571c0..e5eb0d8 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -158,6 +158,13 @@ device i2c 15 on end end end + device ref pch_espi on + chip ec/google/chromeec + use conn0 as mux_conn[0] + use conn1 as mux_conn[1] + device pnp 0c09.0 on end + end + end device ref hda on chip drivers/generic/max98357a register "hid" = ""MX98357A"" @@ -175,14 +182,14 @@ register "usb2_port_number" = "9" register "usb3_port_number" = "1" # SBU & HSL follow CC - device generic 0 on end + device generic 0 alias conn0 on end end chip drivers/intel/pmc_mux/conn register "usb2_port_number" = "4" register "usb3_port_number" = "2" # SBU is fixed, HSL follows CC register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" - device generic 1 on end + device generic 1 alias conn1 on end end end end
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48066 )
Change subject: mb/google/volteer/variant/eldrid: switch to devtree aliases for PMC MUX connectors ......................................................................
Patch Set 1: Code-Review+1
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48066 )
Change subject: mb/google/volteer/variant/eldrid: switch to devtree aliases for PMC MUX connectors ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has uploaded a new patch set (#2) to the change originally created by Scott Chao. ( https://review.coreboot.org/c/coreboot/+/48066 )
Change subject: mb/google/volteer: eldrid: use devtree aliases for PMC MUX connectors ......................................................................
mb/google/volteer: eldrid: use devtree aliases for PMC MUX connectors
Now that soc_get_pmc_mux_device() is gone, the PMC MUX connector devices can be hooked up together via devicetree aliases.
BUG=b:172528109 BRANCH=firmware-volteer-13521.B TEST=built and USB3.0, type-c display work.
Signed-off-by: Scott Chao scott_chao@wistron.corp-partner.google.com Change-Id: Iedf9b972b341064ff62a4443bfa83f69c8c60108 --- M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/48066/2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48066 )
Change subject: mb/google/volteer: eldrid: use devtree aliases for PMC MUX connectors ......................................................................
mb/google/volteer: eldrid: use devtree aliases for PMC MUX connectors
Now that soc_get_pmc_mux_device() is gone, the PMC MUX connector devices can be hooked up together via devicetree aliases.
BUG=b:172528109 BRANCH=firmware-volteer-13521.B TEST=built and USB3.0, type-c display work.
Signed-off-by: Scott Chao scott_chao@wistron.corp-partner.google.com Change-Id: Iedf9b972b341064ff62a4443bfa83f69c8c60108 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48066 Reviewed-by: Zhuohao Lee zhuohao@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 1 file changed, 9 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Zhuohao Lee: Looks good to me, approved Scott Chao: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index 51bc991..129d704 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -168,6 +168,13 @@ device i2c 15 on end end end + device ref pch_espi on + chip ec/google/chromeec + use conn0 as mux_conn[0] + use conn1 as mux_conn[1] + device pnp 0c09.0 on end + end + end device ref hda on chip drivers/generic/max98357a register "hid" = ""MX98357A"" @@ -185,14 +192,14 @@ register "usb2_port_number" = "9" register "usb3_port_number" = "1" # SBU & HSL follow CC - device generic 0 on end + device generic 0 alias conn0 on end end chip drivers/intel/pmc_mux/conn register "usb2_port_number" = "4" register "usb3_port_number" = "2" # SBU is fixed, HSL follows CC register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" - device generic 1 on end + device generic 1 alias conn1 on end end end end
-
Scott Chao (Code Review) -
Tim Wawrzynczak (Code Review)
-
Zhuohao Lee (Code Review)