Change in coreboot[master]: cpu/x86/lapic: Split virtual_wire_mode_init()

[Angel Pons (Code Review)]

Attention is currently required from: Kyösti Mälkki, Werner Zeh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55261 )

Change subject: cpu/x86/lapic: Split virtual_wire_mode_init()
......................................................................

Patch Set 13:

(1 comment)

File src/cpu/x86/lapic/lapic.c:

https://review.coreboot.org/c/coreboot/+/55261/comment/f3eb745d_98280df0 
PS13, Line 67: /* Enable the local APIC */
             : 	if (need_lapic_init())
             : 		enable_lapic();
             : 	else if (!CONFIG(UDELAY_LAPIC))
             : 		disable_lapic();
             : 
             : 	/* This programming is for PIC mode i8259 interrupts to be delivered to CPU
             : 	   while LAPIC is enabled. */
             : 	if (need_lapic_init())
             : 		lapic_virtual_wire_mode_init();
This should be equivalent and simpler:

void setup_lapic(void)
 {
    /* Enable the local APIC */
    if (need_lapic_init()) {
    	enable_lapic();
    	/* This programming is for PIC mode i8259 interrupts
    	   to be delivered to CPU while LAPIC is enabled. */
    	lapic_virtual_wire_mode_init();
    } else if (!CONFIG(UDELAY_LAPIC)) {
    	disable_lapic();
    }
 }