Change in coreboot[master]: acpi: Move ACPI table support out of arch/x86 (5/5)

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40940 )

Change subject: acpi: Move ACPI table support out of arch/x86 (5/5)
......................................................................

acpi: Move ACPI table support out of arch/x86 (5/5)

This change moves all ACPI table support in coreboot currently living
under arch/x86 into common code to make it architecture
independent. ACPI table generation is not really tied to any
architecture and hence it makes sense to move this to its own
directory.

In order to make it easier to review, this change is being split
into multiple CLs. This is change 5/5 which moves the addition of ACPI
table related files from arch/x86/Makefile.inc to acpi/Makefile.inc.

BUG=b:155428745

Change-Id: I8143fd37357aeb0561516450adddc6714d539ada
Signed-off-by: Furquan Shaikh 
---
M src/acpi/Makefile.inc
M src/arch/x86/Makefile.inc
2 files changed, 8 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/40940/1

diff --git a/src/acpi/Makefile.inc b/src/acpi/Makefile.inc
index 068c592..09ff9f1 100644
--- a/src/acpi/Makefile.inc
+++ b/src/acpi/Makefile.inc
@@ -12,4 +12,12 @@

ramstage-y += sata.c

+ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/acpi_tables.c),)
+ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/acpi_tables.c
+endif
+$(eval $(call asl_template,dsdt))
+ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/fadt.c),)
+ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/fadt.c
+endif
+
 endif # CONFIG_GENERATE_ACPI_TABLES
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index aa1f5fe..c29d5ed 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -281,15 +281,6 @@
 ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/reset.c),)
 ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/reset.c
 endif
-ifeq ($(CONFIG_HAVE_ACPI_TABLES),y)
-ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/acpi_tables.c),)
-ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/acpi_tables.c
-endif
-$(eval $(call asl_template,dsdt))
-ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/fadt.c),)
-ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/fadt.c
-endif
-endif # CONFIG_GENERATE_ACPI_TABLES

ramstage-libs ?=

[Furquan Shaikh (Code Review)]

Hello Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40940

to look at the new patch set (#2).

Change subject: acpi: Move ACPI table support out of arch/x86 (5/5)
......................................................................

acpi: Move ACPI table support out of arch/x86 (5/5)

This change moves all ACPI table support in coreboot currently living
under arch/x86 into common code to make it architecture
independent. ACPI table generation is not really tied to any
architecture and hence it makes sense to move this to its own
directory.

In order to make it easier to review, this change is being split
into multiple CLs. This is change 5/5 which moves the addition of ACPI
table related files from arch/x86/Makefile.inc to acpi/Makefile.inc.

BUG=b:155428745

Change-Id: I8143fd37357aeb0561516450adddc6714d539ada
Signed-off-by: Furquan Shaikh 
---
M src/acpi/Makefile.inc
M src/arch/x86/Makefile.inc
2 files changed, 8 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/40940/2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40940 )

Change subject: acpi: Move ACPI table support out of arch/x86 (5/5)
......................................................................

Patch Set 4: Code-Review+1

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40940 )

Change subject: acpi: Move ACPI table support out of arch/x86 (5/5)
......................................................................

Patch Set 4: Code-Review+2

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40940 )

Change subject: acpi: Move ACPI table support out of arch/x86 (5/5)
......................................................................

Patch Set 4: Code-Review+2

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40940 )

Change subject: acpi: Move ACPI table support out of arch/x86 (5/5)
......................................................................

Patch Set 4: Code-Review+2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40940 )

Change subject: acpi: Move ACPI table support out of arch/x86 (5/5)
......................................................................

Patch Set 6: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40940 )

Change subject: acpi: Move ACPI table support out of arch/x86 (5/5)
......................................................................

acpi: Move ACPI table support out of arch/x86 (5/5)

This change moves all ACPI table support in coreboot currently living
under arch/x86 into common code to make it architecture
independent. ACPI table generation is not really tied to any
architecture and hence it makes sense to move this to its own
directory.

In order to make it easier to review, this change is being split
into multiple CLs. This is change 5/5 which moves the addition of ACPI
table related files from arch/x86/Makefile.inc to acpi/Makefile.inc.

BUG=b:155428745

Change-Id: I8143fd37357aeb0561516450adddc6714d539ada
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40940
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Frans Hendriks 
Reviewed-by: Aaron Durbin 
Reviewed-by: Raul Rangel 
Reviewed-by: Duncan Laurie 
---
M src/acpi/Makefile.inc
M src/arch/x86/Makefile.inc
2 files changed, 8 insertions(+), 9 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved
  Aaron Durbin: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, approved
  Frans Hendriks: Looks good to me, but someone else must approve
  Raul Rangel: Looks good to me, approved

diff --git a/src/acpi/Makefile.inc b/src/acpi/Makefile.inc
index 068c592..09ff9f1 100644
--- a/src/acpi/Makefile.inc
+++ b/src/acpi/Makefile.inc
@@ -12,4 +12,12 @@

ramstage-y += sata.c

+ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/acpi_tables.c),)
+ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/acpi_tables.c
+endif
+$(eval $(call asl_template,dsdt))
+ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/fadt.c),)
+ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/fadt.c
+endif
+
 endif # CONFIG_GENERATE_ACPI_TABLES
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index aa1f5fe..c29d5ed 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -281,15 +281,6 @@
 ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/reset.c),)
 ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/reset.c
 endif
-ifeq ($(CONFIG_HAVE_ACPI_TABLES),y)
-ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/acpi_tables.c),)
-ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/acpi_tables.c
-endif
-$(eval $(call asl_template,dsdt))
-ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/fadt.c),)
-ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/fadt.c
-endif
-endif # CONFIG_GENERATE_ACPI_TABLES

ramstage-libs ?=

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40940 )

Change subject: acpi: Move ACPI table support out of arch/x86 (5/5)
......................................................................

Patch Set 7:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3144
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3143
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3142
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3141

Please note: This test is under development and might not be accurate at all!