[S] Change in coreboot[master]: mb/siemens/mc_ehl2: Change to new RTC RV3028-C7

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67101 )

Change subject: mb/siemens/mc_ehl2: Change to new RTC RV3028-C7
......................................................................

mb/siemens/mc_ehl2: Change to new RTC RV3028-C7

Since the latest redesign a new RTC was introduced on mc_ehl2. Instead
of the old RX6110SA the new Micro Crystal RTC RV3028 is used now. Since
the address of this new RTC conflicts with an EEPROM on I2C bus 2, the
new RTC was moved to I2C bus 1.
As the mainboard is not finished yet, there are no incompatibility
issues with this change. Every new mainboard will have the new RTC and
the older mainboards are not delivered yet.

Change-Id: I3dd00855b8c9b22bdea21d3c8563cdb392868751
Signed-off-by: Werner Zeh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67101
Tested-by: build bot (Jenkins) 
Reviewed-by: Mario Scheithauer 
---
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
2 files changed, 28 insertions(+), 10 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Mario Scheithauer: Looks good to me, approved

diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
index 6849245..00875fb 100644
--- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
+++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
@@ -2,7 +2,7 @@

config BOARD_SPECIFIC_OPTIONS
    def_bool y
-	select DRIVERS_I2C_RX6110SA
+	select DRIVERS_I2C_RV3028C7
    select DRIVER_INTEL_I210
    select SOC_INTEL_COMMON_BLOCK_LPC_COMB_ENABLE
    select EHL_TSN_DRIVER
diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
index a1c8ae3..78101d7 100644
--- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
+++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
@@ -123,23 +123,20 @@
    	device pci 14.0 on	end # USB3.1 xHCI

device pci 15.0 on	end # I2C0
-		device pci 15.1 on	end # I2C1
-		device pci 15.2 on	    # I2C2
+		device pci 15.1 on	    # I2C1
    		# Enable external RTC chip
-			chip drivers/i2c/rx6110sa
-				register "bus_speed" = "I2C_SPEED_STANDARD"
-				register "pmon_sampling" = "PMON_SAMPL_256_MS"
-				register "bks_on" = "0"
-				register "bks_off" = "1"
-				register "iocut_en" = "1"
+			chip drivers/i2c/rv3028c7
    			register "set_user_date" = "1"
    			register "user_year" = "04"
    			register "user_month" = "07"
    			register "user_day" = "01"
    			register "user_weekday" = "4"
-				device i2c 0x32 on end  # RTC RX6110 SA
+				register "bckup_sw_mode" = "BACKUP_SW_LEVEL"
+				register "cap_charge" = "CHARGE_OFF"
+				device i2c 0x52 on end  # RTC RV3028-C7
    		end
    	end
+		device pci 15.2 on	end # I2C2
    	device pci 15.3 on	end # I2C3

device pci 16.0 hidden	end # Management Engine Interface 1