Change in coreboot[master]: libpayload: Parse the ACPI RSDP table entry - coreboot-gerrit

7 Mar 2022


      Attention is currently required from: Arthur Heymans.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62576 )
Change subject: libpayload: Parse the ACPI RSDP table entry
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/c/coreboot/+/62576/comment/de4d8947_437f3333 
PS6, Line 271: 	info->acpi_rsdp = cb_unpack64(cb_acpi_rsdp->rsdp_pointer);
Technically shouldn't there be a virt_to_phys() call after unpacking?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62576
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I583cda63c3f0b58f8d198ed5ecea7c4619c7a897
Gerrit-Change-Number: 62576
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Comment-Date: Mon, 07 Mar 2022 16:46:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment