Attention is currently required from: Arthur Heymans, Patrick Rudolph, Jonathan Zhang, Paul Menzel, Jingle Hsu, Angel Pons, Nill Ge, Marc Jones, Subrata Banik, lichenchen.carl, Tim Chu, Shelly Chang.
Hello Arthur Heymans, build bot (Jenkins), Patrick Rudolph, Jonathan Zhang, Paul Menzel, Jingle Hsu, Angel Pons, Nill Ge, Marc Jones, Subrata Banik, lichenchen.carl, Tim Chu, Shelly Chang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63882
to look at the new patch set (#8).
Change subject: arch/x86/smbios.c: Add SMBIOS type 17 for empty DIMM slots
......................................................................
arch/x86/smbios.c: Add SMBIOS type 17 for empty DIMM slots
1. Add Kconfig SMBIOS_TYPE17_EMPTY_SLOT that can create SMBIOS
type 17 tables for empty DIMM slots that don't have DIMM installed,
this feature is desirable for server platforms.
Mainboard can override mainboard_check_slot_exist to avoid
creating empty DIMM tables that don't exist on the board.
2. SMBIOS type 19 and 20 need to ignore meminfo->dimm_cnt array
boundary check when SMBIOS_TYPE17_EMPTY_SLOT is selected,
because meminfo->dimm would contain not only the installed DIMM.
3. Avoid creating type 20 when the DIMM size is zero.
Signed-off-by: Lichenchen Carl lichenchen.carl@bytedance.com
Signed-off-by: Johnny Lin johnny_lin@wiwynn.com
Change-Id: Ia3ff1353667f9d3bd302db42c739b7be9d3f4a32
---
M src/Kconfig
M src/arch/x86/smbios.c
M src/arch/x86/smbios_defaults.c
M src/include/memory_info.h
M src/include/smbios.h
5 files changed, 102 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/63882/8
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3ff1353667f9d3bd302db42c739b7be9d3f4a32
Gerrit-Change-Number: 63882
Gerrit-PatchSet: 8
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Patrick Rudolph
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-MessageType: newpatchset