[XS] Change in coreboot[main]: mb/google/geralt: Create variant Ciri

[Ruihai Zhou (Code Review)]

Attention is currently required from: Hung-Te Lin, Paul Menzel.

Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78954?usp=email )

Change subject: mb/google/geralt: Create variant Ciri
......................................................................

Patch Set 3:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/78954/comment/26fe4428_0f552d13 :
PS2, Line 9:  and enable MAX98390 AMP for it.
> Maybe state, that it’s an exact copy of *Geralt*.

I think it should be enough to say this is a variant of geralt

https://review.coreboot.org/c/coreboot/+/78954/comment/2d102310_58e7d823 :
PS2, Line 9: a
> the

Done

https://review.coreboot.org/c/coreboot/+/78954/comment/11ae1b52_485f1e3a :
PS2, Line 10:
> Please state if future changes are to be expected.

Done

https://review.coreboot.org/c/coreboot/+/78954/comment/9deed3c1_0832495c :
PS2, Line 12: TEST=emerge-geralt coreboot
> I do not know the Chromium OS tooling, but does this build all the variants?

No, not all variants. But I think the build bot will do it.

File src/mainboard/google/geralt/Kconfig:

https://review.coreboot.org/c/coreboot/+/78954/comment/90894d32_0e447afd :
PS2, Line 73: choice
            : 	prompt "Speaker AMP for Geralt"
            : 	default USE_MAX98390 if BOARD_GOOGLE_GERALT || BOARD_GOOGLE_CIRI
            : 
            : config USE_MAX98390
            : 	bool "MAX98390"
            : 
            : config USE_NAU8318
            : 	bool "NAU8318"
> Does this make sense to allow the user to select the speaker AMP?

I guess yes, because for the reference board geralt, MAX98390 and NAU8318 are two choices.