Change in coreboot[master]: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 k...
Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43083 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio ......................................................................
mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio
The current I2C0 bus frequency is 366 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C0 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C0 frequency is 395kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8816cde379d7f0f6b4a2f361ba3025ab8f22411d --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/43083/1
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 24b869c..e77e4bb 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -161,5 +161,49 @@ end end end # PMC + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| chipset_lockdown | CHIPSET_LOCKDOWN_COREBOOT | + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| GSPI1 | Fingerprint MCU | + #| I2C0 | Audio | + #| I2C1 | Touchscreen | + #| I2C2 | WLAN, SAR0 | + #| I2C3 | Camera, SAR1 | + #| I2C5 | Trackpad | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 155, + .scl_hcnt = 75, + .sda_hold = 36, + }, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[5] = { + .speed = I2C_SPEED_FAST, + }, + }" end end
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43083 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43083/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43083/1/src/mainboard/google/voltee... PS1, Line 196: .speed = I2C_SPEED_FAST, trailing whitespace
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43083
to look at the new patch set (#2).
Change subject: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio ......................................................................
mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio
The current I2C0 bus frequency is 366 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C0 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C0 frequency is 395kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8816cde379d7f0f6b4a2f361ba3025ab8f22411d --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/43083/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43083 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43083/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43083/2/src/mainboard/google/voltee... PS2, Line 196: .speed = I2C_SPEED_FAST, trailing whitespace
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43083
to look at the new patch set (#3).
Change subject: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio ......................................................................
mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio
The current I2C0 bus frequency is 366 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C0 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C0 frequency is 395kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8816cde379d7f0f6b4a2f361ba3025ab8f22411d --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/43083/3
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43083
to look at the new patch set (#4).
Change subject: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio ......................................................................
mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio
The current I2C0 bus frequency is 366 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C0 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C0 frequency is 395kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8816cde379d7f0f6b4a2f361ba3025ab8f22411d --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/43083/4
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43083
to look at the new patch set (#5).
Change subject: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio ......................................................................
mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio
The current I2C0 bus frequency is 366 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C0 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C0 frequency is 395kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8816cde379d7f0f6b4a2f361ba3025ab8f22411d --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/43083/5
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43083
to look at the new patch set (#6).
Change subject: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio ......................................................................
mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio
The current I2C0 bus frequency is 366 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C0 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C0 frequency is 395kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8816cde379d7f0f6b4a2f361ba3025ab8f22411d --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/43083/6
Hello build bot (Jenkins), Caveh Jalali, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43083
to look at the new patch set (#7).
Change subject: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio ......................................................................
mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio
The current I2C0 bus frequency is 366 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C0 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C0 frequency is 395kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8816cde379d7f0f6b4a2f361ba3025ab8f22411d --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/43083/7
Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43083 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C0 bus freq closer to 400 kHz for Audio ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Johnny Li (Code Review)