[S] Change in coreboot[main]: mb/google/nissa/var/gothrax: Add probe and GPIO config for touchpanel - coreboot-gerrit

4 Mar 2024


      Attention is currently required from: Kapil Porwal, Nick Vaccaro, Subrata Banik, Yunlong Jia.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80850?usp=email )
Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for touchpanel
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/gothrax/gpio.c:
https://review.coreboot.org/c/coreboot/+/80850/comment/79f8d1e7_d8783304 :
PS1, Line 104: 	if (fw_config_probe(FW_CONFIG(TOUCH_PANEL, TOUCH_PANEL_DISABLE))) {
...
I don't understand what you mean. […]
oh sorry, I misread the code.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80850?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I23c62406a932815ff1cfafe05b70468b1f9cca54
Gerrit-Change-Number: 80850
Gerrit-PatchSet: 1
Gerrit-Owner: Yunlong Jia yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Yunlong Jia yunlong.jia@ecs.corp-partner.google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 04 Mar 2024 02:59:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai ericllai@google.com
Comment-In-Reply-To: Yunlong Jia yunlong.jia@ecs.corp-partner.google.com
Gerrit-MessageType: comment