Attention is currently required from: Henry Sun, Tao Xia, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55035 )
Change subject: mb/google/dedede/var/sasukette: Modify the touch pad slave address
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55035/comment/6957f340_7249e3ba
PS1, Line 10: It will cause one of the touch pad hid identification error.
Please paste that error, and summarize the bug report.
https://review.coreboot.org/c/coreboot/+/55035/comment/8de4ba17_ca8106bb
PS1, Line 14: TEST=Verify OK
Please be more specific.
https://review.coreboot.org/c/coreboot/+/55035/comment/bd8a5da0_da0cb7d2
PS1, Line 17: Change-Id: I09bc12eeca7f34f6e9424e5cbb7f812f3bbfe0de
Please remove this line, as the Change-Id below is used. (Please also remove the blank line.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0bd80baa27dfeb7bcb43f0ca4b02e1228e372a6
Gerrit-Change-Number: 55035
Gerrit-PatchSet: 1
Gerrit-Owner: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jessie Xu
xuyanan@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-CC: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sat, 29 May 2021 07:02:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment