Change in coreboot[master]: soc/intel/common/block/smm: add case intrusion to SMI handler
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39265 )
Change subject: soc/intel/common/block/smm: add case intrusion to SMI handler ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39265/6/src/soc/intel/common/block/... File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/39265/6/src/soc/intel/common/block/... PS6, Line 434: if (!tco_sts)
I guess what Michael meant is that it's only ever called in a TCO SMI, and so it shouldn't be called […]
Note: if we agree that this code should be eliminated by an #if in the southbridge_smi array, that probably should be a separate commit (and this one would apparently be ready to go in and therefore should this comment should be marked resolved.)
-
Patrick Georgi (Code Review)